Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve EuiBasicTable caption #2782

Merged
merged 11 commits into from
Jan 29, 2020
Merged

Improve EuiBasicTable caption #2782

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
5757dc8
improve EuiBasicTable caption
andreadelrio Jan 22, 2020
449d508
cl
andreadelrio Jan 22, 2020
49e571d
Merge remote-tracking branch 'upstream/master' into basic-table-caption
andreadelrio Jan 23, 2020
d89a6c9
added tableCaption prop and updated cl
andreadelrio Jan 23, 2020
d79f679
changed default caption to list column names
andreadelrio Jan 25, 2020
84b2998
updated cl
andreadelrio Jan 25, 2020
2fa4d05
listing number of rows as caption
andreadelrio Jan 27, 2020
bd29385
updated prop description in docs
andreadelrio Jan 27, 2020
d7e5b05
Merge remote-tracking branch 'upstream/master' into basic-table-caption
andreadelrio Jan 29, 2020
247cbe1
removed i18n from tableCaption
andreadelrio Jan 29, 2020
153cdf0
fixing tests
andreadelrio Jan 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
- Added `data-test-subj` to the `EuiContextMenuItem` in `EuiTablePagination` ([#2778](https://github.com/elastic/eui/pull/2778))
- Improved compressed `EuiPagination` by including active and last page numbers ([#2779](https://github.com/elastic/eui/pull/2779))
- Converted `EuiSuperSelect` to TypeScript ([#2776](https://github.com/elastic/eui/pull/2776))
- Added `tableCaption` prop to `EuiBasicTable` and improved the default one ([#2782](https://github.com/elastic/eui/pull/2782))

**Bug fixes**

Expand Down
6 changes: 6 additions & 0 deletions src-docs/src/views/tables/basic/props_info.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,12 @@ export const propsInfo = {
required: false,
type: { name: '(criteria: #Criteria) => void' },
},
tableCaption: {
description:
'Describes the content of the table. If not specified, the caption will be "Below is a table of {itemCount} items."',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gonna want to adjust your docs copy to match your recent changes.

required: false,
type: { name: 'string' },
},
tableLayout: {
description:
'Sets the table-layout CSS property. Note that auto tableLayout prevents truncateText from working properly.',
Expand Down
Loading