Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove padding on euipage breakpoint for now #282

Merged
merged 5 commits into from
Jan 10, 2018

Conversation

snide
Copy link
Contributor

@snide snide commented Jan 10, 2018

Fixes #281

The responsive breakpoint we have set up works fine in EUI because page assumes it's flush against the browser sides, but Kibana isn't quite there yet. This change adds the padding back, which will play nicer with Kibana and only operate slightly worse for native EUI pages.

@snide snide requested a review from cjcenizal January 10, 2018 17:42
Copy link
Contributor

@cjcenizal cjcenizal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM one nitpick about the CHANGELOG. 😝

CHANGELOG.md Outdated
@@ -5,6 +5,7 @@

**Bug fixes**

- Remove padding on euipage mobile breakpoint. [(#282)](https://github.com/elastic/eui/pull/282)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick: <EuiPage>

@snide snide merged commit 1042eee into elastic:master Jan 10, 2018
@snide snide deleted the fix/responsive_kibana branch January 10, 2018 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants