Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #2217 : removed duplicate icons #2908

Merged
merged 3 commits into from
Feb 24, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,10 @@
- Fixed building dev & docs on Windows ([#2847](https://github.com/elastic/eui/pull/2847))
- Fixed a bug in `EuiDataGrid` causing the first cell to autofocus if interactive ([#2872](https://github.com/elastic/eui/pull/2872))

**Breaking changes**

- Removed `visControls` and `visHeatmap` duplicate icons from docs ([#2908](https://github.com/elastic/eui/pull/2908))

## [`19.0.0`](https://github.com/elastic/eui/tree/v19.0.0)

- Added `cheer` glyph to `EuiIcon` ([#2814](https://github.com/elastic/eui/pull/2814))
Expand Down
2 changes: 0 additions & 2 deletions src-docs/src/views/icon/icons.js
Original file line number Diff line number Diff line change
Expand Up @@ -201,10 +201,8 @@ export const iconTypes = [
'visBarHorizontalStacked',
'visBarVertical',
'visBarVerticalStacked',
'visControls',
'visGauge',
'visGoal',
'visHeatmap',
'visLine',
'visMapCoordinate',
'visMapRegion',
Expand Down
34 changes: 0 additions & 34 deletions src/components/icon/__snapshots__/icon.test.tsx.snap
Original file line number Diff line number Diff line change
Expand Up @@ -8239,23 +8239,6 @@ exports[`EuiIcon props type visBarVerticalStacked is rendered 1`] = `
</svg>
`;

exports[`EuiIcon props type visControls is rendered 1`] = `
<svg
aria-hidden="true"
class="euiIcon euiIcon--medium euiIcon-isLoaded"
focusable="false"
height="16"
role="img"
viewBox="0 0 16 16"
width="16"
xmlns="http://www.w3.org/2000/svg"
>
<path
d="M8.05 10a2.5 2.5 0 014.9 0H15v1h-2.05a2.5 2.5 0 01-4.9 0H1v-1h7.05zm-.1-4a2.5 2.5 0 01-4.9 0H1V5h2.05a2.5 2.5 0 014.9 0H15v1H7.95zM4 5.5a1.5 1.5 0 103 0 1.5 1.5 0 00-3 0zm8 5a1.5 1.5 0 10-3 0 1.5 1.5 0 003 0z"
/>
</svg>
`;

exports[`EuiIcon props type visGauge is rendered 1`] = `
<svg
aria-hidden="true"
Expand Down Expand Up @@ -8290,23 +8273,6 @@ exports[`EuiIcon props type visGoal is rendered 1`] = `
</svg>
`;

exports[`EuiIcon props type visHeatmap is rendered 1`] = `
<svg
aria-hidden="true"
class="euiIcon euiIcon--medium euiIcon-isLoaded"
focusable="false"
height="16"
role="img"
viewBox="0 0 16 16"
width="16"
xmlns="http://www.w3.org/2000/svg"
>
<path
d="M12 9a3 3 0 110 6 3 3 0 010-6zm0 1a2 2 0 100 4 2 2 0 000-4zM4 2a2 2 0 110 4 2 2 0 010-4zm0 1a1 1 0 100 2 1 1 0 000-2zm0 5a4 4 0 110 8 4 4 0 010-8zm0 1a3 3 0 100 6 3 3 0 000-6zm8-9a4 4 0 110 8 4 4 0 010-8zm0 1a3 3 0 100 6 3 3 0 000-6z"
/>
</svg>
`;

exports[`EuiIcon props type visLine is rendered 1`] = `
<svg
aria-hidden="true"
Expand Down
16 changes: 0 additions & 16 deletions src/components/icon/assets/vis_controls.js

This file was deleted.

3 changes: 0 additions & 3 deletions src/components/icon/assets/vis_controls.svg

This file was deleted.

16 changes: 0 additions & 16 deletions src/components/icon/assets/vis_heatmap.js

This file was deleted.

3 changes: 0 additions & 3 deletions src/components/icon/assets/vis_heatmap.svg

This file was deleted.

2 changes: 0 additions & 2 deletions src/components/icon/icon.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -333,10 +333,8 @@ const typeToPathMap = {
visBarHorizontalStacked: 'vis_bar_horizontal_stacked',
visBarVertical: 'vis_bar_vertical',
visBarVerticalStacked: 'vis_bar_vertical_stacked',
visControls: 'vis_controls',
visGauge: 'vis_gauge',
visGoal: 'vis_goal',
visHeatmap: 'vis_heatmap',
visLine: 'vis_line',
visMapCoordinate: 'vis_map_coordinate',
visMapRegion: 'vis_map_region',
Expand Down