-
Notifications
You must be signed in to change notification settings - Fork 841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added badge group component #2921
Conversation
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
@cchaos I don't know why scss isn't being applied . Also can you let me know how to test new component |
Jenkins, test this |
Preview documentation changes for this PR: https://eui.elastic.co/pr_2921/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for tackling this one. I'm going to start the review just on the component itself. Side note: we understand that our wiki/contributing docs are lacking full details and we're working on improving them so bear with us as we realize there's a lot of work that goes into creating new components.
The reason your styles are not getting compiled is because your not importing the new file you created anywhere. Just look for the nearest _index.scss
file and add the import. I'll have to wait for that update to do a full test of the layout.
Another piece this needs is a test badge_group_test.ts
file. You can duplicate and change the contents of similar files in this folder. Then you run yarn run test-unit
to update the snapshots.
Co-Authored-By: Caroline Horn <549577+cchaos@users.noreply.github.com>
@anishagg17 Please also be sure have an ESLint plugin enabled in your IDE so that the tests and builds will pass. |
Sure @cchaos |
Co-Authored-By: Caroline Horn <549577+cchaos@users.noreply.github.com>
Co-Authored-By: Caroline Horn <549577+cchaos@users.noreply.github.com>
@cchoas please recheck this |
Jenkins, test this |
Preview documentation changes for this PR: https://eui.elastic.co/pr_2921/ |
@anishagg17 Thanks for getting this one all setup. I think I'll need to help to get it over the line because it gets intricate with wrapping and truncation which is the main problem we're trying to solve. This one is mainly about having the CSS. |
Okay, @cchoas |
Hey @anishagg17 , again thanks for getting this one started. As I worked on it, it kind of morphed into quite a simpler component. I started a clean PR over here #2942, so I'm going to close this one. |
Summary
Fixes : #2871
added badge group component
Checklist