Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added default sort order to dataGrid #2987

Merged
merged 4 commits into from
Mar 6, 2020

Conversation

anishagg17
Copy link
Contributor

@anishagg17 anishagg17 commented Mar 5, 2020

Summary

Fixes : #2974
added default sort order to dataGrid

Checklist

  • Check against all themes for compatibility in both light and dark modes
  • Checked in mobile
  • Checked in IE11 and Firefox
  • Props have proper autodocs
  • Added documentation examples
  • Added or updated jest tests
  • Checked for breaking changes and labeled appropriately
  • Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@kibanamachine
Copy link

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@anishagg17
Copy link
Contributor Author

@myasonik @chandlerprall I have added default 'desc' property to version and date column
and default 'asc' property to name field

if no default is supplied as a prop 'asc' sorting would be performed

@chandlerprall chandlerprall self-requested a review March 6, 2020 19:10
@chandlerprall chandlerprall self-assigned this Mar 6, 2020
Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple changes requested, also: we'll want to add a defaultSortDirection prop on EuiDataGridSchemaDetector which should be used if the value isn't overridden by a column.

Loosely, initialSortDirection = column.defaultSortDirection || columnSchema.defaultSortDirection || 'asc'

CHANGELOG.md Outdated Show resolved Hide resolved
src/components/datagrid/data_grid_types.ts Outdated Show resolved Hide resolved
src/components/datagrid/data_grid_types.ts Outdated Show resolved Hide resolved
@anishagg17
Copy link
Contributor Author

@chandlerprall changes have been made

Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM! Pulled and tested locally

@chandlerprall
Copy link
Contributor

jenkins test this

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_2987/

@chandlerprall chandlerprall merged commit 9a52f2f into elastic:master Mar 6, 2020
@anishagg17 anishagg17 deleted the default branch March 21, 2020 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DataGrid should allow for a default sort order
3 participants