-
Notifications
You must be signed in to change notification settings - Fork 842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added default sort order to dataGrid #2987
Conversation
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
@myasonik @chandlerprall I have added default 'desc' property to version and date column if no default is supplied as a prop 'asc' sorting would be performed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple changes requested, also: we'll want to add a defaultSortDirection
prop on EuiDataGridSchemaDetector
which should be used if the value isn't overridden by a column.
Loosely, initialSortDirection = column.defaultSortDirection || columnSchema.defaultSortDirection || 'asc'
@chandlerprall changes have been made |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM! Pulled and tested locally
jenkins test this |
Preview documentation changes for this PR: https://eui.elastic.co/pr_2987/ |
Summary
Fixes : #2974
added default sort order to dataGrid
Checklist