Removed EuiKeyPadMenuItemButton in favor of just EuiKeyPadMenuItem

[anishagg17]

Summary

Fixes: #2098
removed EuiKeyPadMenuItemButton

Checklist

- [ ] Check against all themes for compatibility in both light and dark modes
- [ ] Checked in mobile
- [ ] Checked in IE11 and Firefox
- [ ] Props have proper autodocs
- [ ] Added documentation examples

• Added or updated jest tests
  - [ ] Checked for breaking changes and labeled appropriately
  - [ ] Checked for accessibility including keyboard-only and screenreader modes
• A changelog entry exists and is marked appropriately

[kibanamachine]

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

[myasonik]

jenkins test this

[kibanamachine]

Preview documentation changes for this PR: https://eui.elastic.co/pr_3062/

[cchaos]

The example text here https://github.com/elastic/eui/pull/3062/files#diff-4b25667c0abd98194144ace12c39a8beR88-R90 also needs to be updated

[anishagg17]

All changes have been made

[cchaos]

Jenkins, test this

[kibanamachine]

Preview documentation changes for this PR: https://eui.elastic.co/pr_3062/

[cchaos]

This example text needs to be updated:

eui/src-docs/src/views/key_pad_menu/key_pad_menu_example.js

Lines 87 to 91 in ab84c3c

	<p>
	The KeyPadMenuItem component is a link by default, but you can swap it
	out for a KeyPadMenuItemButton if you want <EuiCode>onClick</EuiCode>{' '}
	behavior.
	</p>

[cchaos]

Almost missed a major part of the issue. The rendered element needs to be a button tag if it's an onClick and an a tag if there's an href.

[cchaos]

jenkins, test this

[kibanamachine]

Preview documentation changes for this PR: https://eui.elastic.co/pr_3062/

[cchaos]

Once the changelog has been updated this should be good to go. Thanks 👍

[anishagg17]

Change Log has been shifted to correct position

[cchaos]

Jenkins, test this

[kibanamachine]

Preview documentation changes for this PR: https://eui.elastic.co/pr_3062/