[EuiComboBox] Added sortMatchesBy prop
#3089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cchaos
suggested changes
Mar 16, 2020
Co-Authored-By: Caroline Horn <549577+cchaos@users.noreply.github.com>
|
@anishagg17 You'll still need to update the docs with the new prop name and add tests. |
|
I have already updated docs with an example showing startsWith property This test has some linting error can you please help me by fixing it
|
cchaos
suggested changes
Mar 18, 2020
Co-Authored-By: Caroline Horn <549577+cchaos@users.noreply.github.com>
Co-Authored-By: Caroline Horn <549577+cchaos@users.noreply.github.com>
|
Jenkins, test this |
thompsongl
suggested changes
Mar 18, 2020
Co-Authored-By: Greg Thompson <thompsongl@users.noreply.github.com>
Co-Authored-By: Greg Thompson <thompsongl@users.noreply.github.com>
|
jenkins test this |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3089/ |
cchaos
approved these changes
Mar 18, 2020
cchaos
changed the title
sortMatchesBy prop
thompsongl
approved these changes
Mar 19, 2020
|
jenkins test this |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3089/ |
This was referenced Jun 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes: #1767 & Fixes #652
added startingWith prop to combobox, it can be seen in action on the last combobox demo in the view section
Checklist
- [ ] Check against all themes for compatibility in both light and dark modes- [ ] Checked in mobile- [ ] Checked in IE11 and Firefox- [ ] Checked for breaking changes and labeled appropriately- [ ] Checked for accessibility including keyboard-only and screenreader modes