fixing Issue #2998 on Data Grid Overlap #3123
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this issue is because of the positions of components of guideSideNav and guidePageContent, I have to change the z-index value of guidePageContent so that these components don't overlap and I set z-index: auto to xs,s Breakpoint.
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
|
💚 CLA has been signed |
|
Welcome @sharvan-sharma ! Can you please sign the CLA? Just by quickly looking at your screenshots, I don't think this is quite the behavior we'd expect. The guide page content (white area) should never overlap the sidebar navigation. Instead, the layout needs to continue to reduce the width of the guide page content. |
|
ok, I look into this and make changes accordingly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this issue is because of the positions of components of guideSideNav and guidePageContent, I have to change the z-index value of guidePageContent so that these components don't overlap and I set z-index: auto to xs,s Breakpoint. Now, the whole guidePageContent component act as a Slider.
Summary
Fixes #2998
