Improving EuiButtonEmpty focus state for color type text #3135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3135/ |
|
I think those tests are flakey. Jenkins, test this |
snide
approved these changes
Mar 20, 2020
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3135/ |
|
jenkins test this |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3135/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a darker background on focus state for
EuiButtonEmptywhen thecolortype istext.The same background color is used in other components like:
EuiButtonIconEuiButtonToggleI think it makes sense that all the buttons that allow the color type text to have the same background color on focus state.
The issue
As we can see, the previous focus state background color wouldn't work in situations like this:
Color contrast a11y
With this new color the contrast decreases a little bit but it still ok.
Checklist
[ ] Checked in mobile[ ] Props have proper autodocs[ ] Added documentation examples[ ] Added or updated jest tests[ ] Checked for breaking changes and labeled appropriately