Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiNavDrawer] Fix scrolling in mobile view #3174

Merged
merged 4 commits into from
Mar 27, 2020
Merged

[EuiNavDrawer] Fix scrolling in mobile view #3174

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
669e04a
navdrawer scrollable in mobile view
lokeshrana9999 Mar 26, 2020
6f4e62e
Updated CHANGELOG.md
lokeshrana9999 Mar 26, 2020
7d63cd2
EuiNavDrawer mobile scroll issue fixed by EuiFlexgroup responsive pro…
lokeshrana9999 Mar 27, 2020
2704418
Fixing cl
cchaos Mar 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

- Added `delimiter` prop to `EuiComboBox` ([#3104](https://github.com/elastic/eui/pull/3104))

**Bug Fixes**

- Fixed `EuiNavDrawer` scrolling issue on mobile ([#3174](https://github.com/elastic/eui/pull/3174))

## [`22.0.0`](https://github.com/elastic/eui/tree/v22.0.0)

- Replaced various `lodash` functions with native functions ([#3053](https://github.com/elastic/eui/pull/3053))
Expand Down
6 changes: 3 additions & 3 deletions src/components/nav_drawer/__snapshots__/nav_drawer.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ exports[`EuiNavDrawer is rendered 1`] = `
class="euiNavDrawer euiNavDrawer-isCollapsed euiNavDrawer-flyoutIsCollapsed"
>
<div
class="euiFlexGroup euiFlexGroup--directionRow euiFlexGroup--responsive"
class="euiFlexGroup euiFlexGroup--directionRow"
>
<div
class="euiFlexItem euiFlexItem--flexGrowZero"
Expand Down Expand Up @@ -266,7 +266,7 @@ exports[`EuiNavDrawer renders with falsy children 1`] = `
class="euiNavDrawer euiNavDrawer-isCollapsed euiNavDrawer-flyoutIsCollapsed"
>
<div
class="euiFlexGroup euiFlexGroup--directionRow euiFlexGroup--responsive"
class="euiFlexGroup euiFlexGroup--directionRow"
>
<div
class="euiFlexItem euiFlexItem--flexGrowZero"
Expand Down Expand Up @@ -473,7 +473,7 @@ exports[`EuiNavDrawer renders with fragments 1`] = `
class="euiNavDrawer euiNavDrawer-isCollapsed euiNavDrawer-flyoutIsCollapsed"
>
<div
class="euiFlexGroup euiFlexGroup--directionRow euiFlexGroup--responsive"
class="euiFlexGroup euiFlexGroup--directionRow"
>
<div
class="euiFlexItem euiFlexItem--flexGrowZero"
Expand Down
2 changes: 1 addition & 1 deletion src/components/nav_drawer/nav_drawer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -347,7 +347,7 @@ export class EuiNavDrawer extends Component {
onOutsideClick={() => this.closeBoth()}
isDisabled={this.state.outsideClickDisabled}>
<nav className={classes} {...rest}>
<EuiFlexGroup gutterSize="none">
<EuiFlexGroup gutterSize="none" responsive={false}>
<EuiFlexItem grow={false}>
<div
id={MENU_ELEMENT_ID}
Expand Down