Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix EuiModal close button position to prevent from overlapping with the title #3176

Merged

Conversation

elizabetdev
Copy link
Contributor

Summary

Closes #3149

This PR fixes the close button position to prevent it from overlapping with the title.

modal-title-close-button-issue@2x

Summarize your PR. If it includes design elements include a screenshot or gif.

Checklist

  • Check against all themes for compatibility in both light and dark modes
  • Checked in mobile
  • Checked in IE11 and Firefox
  • [ ] Props have proper autodocs
  • [ ] Added documentation examples
  • [ ] Added or updated jest tests
  • [ ] Checked for breaking changes and labeled appropriately
  • [ ] Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3176/

@elizabetdev elizabetdev requested a review from cchaos March 26, 2020 17:26
Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me!
Screen Shot 2020-03-26 at 14 10 41 PM

@elizabetdev elizabetdev merged commit 93057ac into elastic:master Mar 26, 2020
elizabetdev added a commit to elizabetdev/eui that referenced this pull request Mar 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EuiModal title can get overlapped by the close button
3 participants