Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extended types for ReactDatePicker's startDate and endDate to allow null #3343

Merged
merged 2 commits into from
Apr 21, 2020
+3 −2
Merged

Extended types for ReactDatePicker's startDate and endDate to allow null #3343

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4ab685a
Extended types for ReactDatePicker's startDate and endDate to allow null
chandlerprall Apr 17, 2020
af761dc
changelog
chandlerprall Apr 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

- Added `showCloseButton` and `dockedBreakpoint` flexibility to `EuiCollapsibleNav` ([#3330](https://github.com/elastic/eui/pull/3330))
- Added `panelStyle` prop to `EuiPopover` to distinguish style object configuration ([#3329](https://github.com/elastic/eui/pull/3329))
- Extended `EuiDatePicker`'s `startDate` and `endDate` types to accept `null` values for better interoperability ([#3343](https://github.com/elastic/eui/pull/3343))

**Bug Fixes**

Expand Down
4 changes: 2 additions & 2 deletions src/components/date_picker/react-datepicker.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ export interface ReactDatePickerProps {
disabled?: boolean;
disabledKeyboardNavigation?: boolean;
dropdownMode?: 'scroll' | 'select';
endDate?: moment.Moment;
endDate?: moment.Moment | null;
excludeDates?: moment.Moment[];
excludeTimes?: moment.Moment[];
filterDate?(date: moment.Moment): boolean;
Expand Down Expand Up @@ -177,7 +177,7 @@ export interface ReactDatePickerProps {
showTimeSelectOnly?: boolean;
showWeekNumbers?: boolean;
showYearDropdown?: boolean;
startDate?: moment.Moment;
startDate?: moment.Moment | null;
startOpen?: boolean;
tabIndex?: number;
timeCaption?: string;
Expand Down