Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EuiHeader Padding & EuiDescribedFormGroup Shrinking Bugs #3369

Merged
merged 9 commits into from
Apr 22, 2020
Merged

EuiHeader Padding & EuiDescribedFormGroup Shrinking Bugs #3369

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
c4855ba
rm extra padding; issues with map header size calc
MichaelMarcialis Apr 21, 2020
6d2bc16
rm unneeded display block rule
MichaelMarcialis Apr 22, 2020
bfa519d
fix bug for EuiDescribedFormGroup not shrinking
MichaelMarcialis Apr 22, 2020
8abd7a0
update changelog
MichaelMarcialis Apr 22, 2020
019de48
Merge branch 'master' of github.com:elastic/eui into bug/new-nav-css
MichaelMarcialis Apr 22, 2020
6e0f27f
add links to changelog
MichaelMarcialis Apr 22, 2020
fc2f590
Update CHANGELOG.md
Apr 22, 2020
2a4f7f0
added maintainer comment
MichaelMarcialis Apr 22, 2020
7022bc6
Moved CL line
cchaos Apr 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ No public interface changes since `23.0.0`.
- Extended `EuiDatePicker`'s `startDate` and `endDate` types to accept `null` values for better interoperability ([#3343](https://github.com/elastic/eui/pull/3343))
- Added `EuiCommentList` component ([#3344](https://github.com/elastic/eui/pull/3344))
- Added secondary color value input element to `EuiColorPicker` ([#3336](https://github.com/elastic/eui/pull/3336))
- Removed additional padding applied to `$euiHeaderHeightCompensation` when `EuiHeader` is fixed ([#3369](https://github.com/elastic/eui/pull/3369))

**Bug Fixes**

Expand All @@ -19,6 +20,7 @@ No public interface changes since `23.0.0`.
- Fixed `EuiPopover` positioning from being overridden by `style` prop ([#3329](https://github.com/elastic/eui/pull/3329))
- Fixed `EuiCodeBlock` not copying updated content ([#3351](https://github.com/elastic/eui/pull/3351))
- Fixed alignment of popover of end date of `EuiDatePickerRange` ([#3359](https://github.com/elastic/eui/pull/3359))
- Fixed `EuiDescribedFormGroup` issue that prevented it from shrinking down properly in smaller viewports ([#3369](https://github.com/elastic/eui/pull/3369))

**Breaking changes**

Expand Down
3 changes: 1 addition & 2 deletions src/components/form/described_form_group/_described_form_group.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,7 @@
}

.euiDescribedFormGroup__fields {
width: $euiFormMaxWidth;
max-width: 100%;
min-width: 0; // Needed to support shrinking appropriately with viewport (prevents x-axis content overflow)
}

.euiDescribedFormGroup__fieldPadding {
Expand Down
1 change: 0 additions & 1 deletion src/components/form/file_picker/_file_picker.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,6 @@
@include euiFontSizeS;
@include euiTextTruncate;
line-height: $euiSize;
display: block;
snide marked this conversation as resolved.
Show resolved Hide resolved

// make normal sized prompt look like placeholder
.euiFilePicker:not(.euiFilePicker--large):not(.euiFilePicker-hasFiles) & {
Expand Down
2 changes: 1 addition & 1 deletion src/components/header/_header.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,5 +20,5 @@
}

.euiBody--headerIsFixed {
padding-top: $euiHeaderHeightCompensation + $euiSizeS; // Extra padding to account for the shadow
padding-top: $euiHeaderHeightCompensation;
}