-
Notifications
You must be signed in to change notification settings - Fork 841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EuiCard] Allow custom component for image prop #3370
[EuiCard] Allow custom component for image prop #3370
Conversation
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
fd483b2
to
e16b8df
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 Thanks @TAYTS .
Just a could suggestions. Also, can you update one of the image cards to pass a custom element. It can just be as simple as:
<EuiCard
image={<div><img src="...unsplash source url..." /></div>}
...rest of the props...
</EuiCard>
J, test this |
Preview documentation changes for this PR: https://eui.elastic.co/pr_3370/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Checked in IE, FF and Safari and the updated example still renders as it did. I'll just push a couple text updates then it will be good to merge! Thanks again @TAYTS
retest |
Summary
Issue: #3341
Added
ReactElement
to theEuiCard
image
prop to allow passing custom component.Checklist
- [ ] Check against all themes for compatibility in both light and dark modes- [ ] Checked in IE11 and Firefox- [ ] Added or updated jest tests- [ ] Checked for breaking changes and labeled appropriately- [ ] Checked for accessibility including keyboard-only and screenreader modes