-
Notifications
You must be signed in to change notification settings - Fork 842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EuiInMemoryTable] Fixed data reset on selection change. #3419
[EuiInMemoryTable] Fixed data reset on selection change. #3419
Conversation
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch, and thanks for opening this to fix!
is there an issue with the |
I think they are intentional as there are some eui/src-docs/src/views/tables/data_store.js Lines 34 to 45 in cc6040b
|
@chandlerprall Thanks for the review. Changes committed 👍 |
jenkins test this |
Preview documentation changes for this PR: https://eui.elastic.co/pr_3419/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM; Pulled and tried to break this locally, couldn't get it to not work.
Summary
PR #3371 introduces a new issue when a filter is set and when we try to select a row the data is reset as shown in the screenshot. This issue can be found at https://eui.elastic.co/pr_3371/.
Before
After
Checklist
- [ ] Props have proper autodocs- [ ] Added documentation examples- [ ] Added or updated jest tests- [ ] Checked for accessibility including keyboard-only and screenreader modes