Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiInMemoryTable] Fixed data reset on selection change. #3419

Merged
merged 5 commits into from
May 5, 2020

Conversation

ashikmeerankutty
Copy link
Contributor

@ashikmeerankutty ashikmeerankutty commented May 3, 2020

Summary

PR #3371 introduces a new issue when a filter is set and when we try to select a row the data is reset as shown in the screenshot. This issue can be found at https://eui.elastic.co/pr_3371/.

Before

Screen Cast 2020-05-03 at 9 48 25 PM

After

Screen Cast 2020-05-03 at 9 58 07 PM

Checklist

  • Check against all themes for compatibility in both light and dark modes
  • Checked in mobile
  • Checked in IE11 and Firefox
    - [ ] Props have proper autodocs
    - [ ] Added documentation examples
    - [ ] Added or updated jest tests
  • Checked for breaking changes and labeled appropriately
    - [ ] Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@kibanamachine
Copy link

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@chandlerprall chandlerprall self-requested a review May 4, 2020 16:40
Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, and thanks for opening this to fix!

src/components/basic_table/in_memory_table.tsx Outdated Show resolved Hide resolved
@anishagg17
Copy link
Contributor

is there an issue with the dataStore function since some names are empty or is it intentional?

@ashikmeerankutty
Copy link
Contributor Author

is there an issue with the dataStore function since some names are empty or is it intentional?

I think they are intentional as there are some null and undefined values in first name as you can see in

const firstNames = [
'Very long first name that will wrap or be truncated',
'Another very long first name which will wrap or be truncated',
'Clinton',
'Igor',
undefined,
'Drew',
null,
'Rashid',
undefined,
'John',
];

@ashikmeerankutty
Copy link
Contributor Author

@chandlerprall Thanks for the review. Changes committed 👍

@chandlerprall
Copy link
Contributor

jenkins test this

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3419/

Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM; Pulled and tried to break this locally, couldn't get it to not work.

@chandlerprall chandlerprall merged commit 7f5ef70 into elastic:master May 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants