-
Notifications
You must be signed in to change notification settings - Fork 842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EuiCodeEditor] Console error when using the editor without import the default theme #3454
Conversation
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the background & fix!
Can you please add a bugfix changelog entry to CHANGELOG.md referencing this PR? After that, this will be good to merge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After a slack conversation with the team, instead of defaulting to github
we should go back to passing an undefined
theme by default - EUI applies some custom style rules in our CSS build, rather than through brace's theme
configuration.
@chandlerprall is not sure we should pass |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The previous PR's goal was adding documentation around the theme
prop, changing the default was secondary and probably wasn't the right thing to merge with. I like your update to textmate
, and confirmed everything locally runs without errors when using only those defaults.
undefined
would be fine as textmate
is still the underlying default, but being explicit here helps readability
Summary
In #2970 the default value for the theme was set to
github
. As a result, now we have many places inKibana
where we need to import this theme even if we don't want to specify theme (remind you it's optional property).Related issue in Kibana repo:
elastic/kibana#56424
I think if we decided to set
github
as a default theme, it should be loaded hereChecklist