Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removes errant console.logs from EuiTour #3513

Merged
merged 1 commit into from
May 26, 2020

Conversation

dimitropoulos
Copy link
Contributor

@dimitropoulos dimitropoulos commented May 26, 2020

see: #2766 (comment)

I noticed over the weekend whilst exploring EuiTour that there are console.log statements that are firing when you step through. I checked with @thompsongl and it appears that these were added during development with the intention of removal prior to merge. This PR removes them.

Check against all themes for compatibility in both light and dark modes

  • [ ] Checked in mobile
  • [ ] Checked in IE11 and Firefox
  • [ ] Props have proper autodocs
  • [ ] Added documentation examples
    Added or updated jest tests
    Checked for breaking changes and labeled appropriately
  • [ ] Checked for accessibility including keyboard-only and screenreader modes
    A changelog entry exists and is marked appropriately (it seemed to me that a changelog for such a thing is not necessary but I'm happy to add one if anyone feels it adds value)

@kibanamachine
Copy link

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@dimitropoulos dimitropoulos mentioned this pull request May 26, 2020
8 tasks
@chandlerprall
Copy link
Contributor

Good to have you back in the repo 😺

Could you expand the PR description to include the goal? It should keep the reference to the source comment, but not having to jump to another page and digest a comment thread will help review and if someone digs through the commit log in the future it makes the change easier to understand. It'd also be nice to retain the reference checklist, even if most of it is unapplicable and crossed out.

Otherwise, this looks good to go. ❤️

@chandlerprall
Copy link
Contributor

jenkins test this

@dimitropoulos
Copy link
Contributor Author

dimitropoulos commented May 26, 2020

absolutely! sorry :)

I made this PR from GitKraken and the checklist isn't visible there. I'll go grab one.

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3513/

@chandlerprall chandlerprall merged commit 454c734 into elastic:master May 26, 2020
@dimitropoulos dimitropoulos deleted the removes-console-logs branch May 26, 2020 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants