removes errant console.log
s from EuiTour
#3513
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see: #2766 (comment)
I noticed over the weekend whilst exploring EuiTour that there are
console.log
statements that are firing when you step through. I checked with @thompsongl and it appears that these were added during development with the intention of removal prior to merge. This PR removes them.Check against all themes for compatibility in both light and dark modes
[ ] Checked in mobile[ ] Checked in IE11 and Firefox[ ] Props have proper autodocs[ ] Added documentation examplesAdded or updated jest testsChecked for breaking changes and labeled appropriately[ ] Checked for accessibility including keyboard-only and screenreader modesA changelog entry exists and is marked appropriately(it seemed to me that a changelog for such a thing is not necessary but I'm happy to add one if anyone feels it adds value)