Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Amsterdam] Improve modals #3515

Merged
merged 7 commits into from
May 29, 2020
Merged

[Amsterdam] Improve modals #3515

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
7a1ea77
Remove modal border & improve overlay color
johnbarrierwilson May 26, 2020
b6f11fb
Remove amsterdam modal border-radius
johnbarrierwilson May 26, 2020
061c980
Adjust overlay mask transparency
johnbarrierwilson May 26, 2020
1d0e0fa
Add changes to CHANGELOG
johnbarrierwilson May 26, 2020
b9a4fc6
Merge branch 'master' into amsterdam/modals
johnbarrierwilson May 26, 2020
22c287f
Adjust EuiImage caption for darker overlay
johnbarrierwilson May 28, 2020
b1f297f
Merge branch 'master' into amsterdam/modals
johnbarrierwilson May 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,10 @@

- Removed `src-framer` files from the repository ([#3487](https://github.com/elastic/eui/pull/3487))

**Theme: Amsterdam**

- Removed borders `EuiModal` ([#3515](https://github.com/elastic/eui/pull/3515))
- Improve `EuiOverlayMask` colors ([#3515](https://github.com/elastic/eui/pull/3515))

## [`24.0.0`](https://github.com/elastic/eui/tree/v24.0.0)

Expand Down
6 changes: 6 additions & 0 deletions src/themes/eui-amsterdam/overrides/_image.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
.euiImage-isFullScreen {
.euiImage__caption {
color: $euiColorGhost;
text-shadow: 0 1px 2px transparentize($euiColorInk, .6);
}
}
3 changes: 3 additions & 0 deletions src/themes/eui-amsterdam/overrides/_index.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
@import 'button';
@import 'button_empty';
@import 'button_group';
@import 'image';
@import 'modal';
@import 'overlay_mask';
@import 'text';
3 changes: 3 additions & 0 deletions src/themes/eui-amsterdam/overrides/_modal.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
.euiModal {
border: none;
}
3 changes: 3 additions & 0 deletions src/themes/eui-amsterdam/overrides/_overlay_mask.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
.euiOverlayMask {
background: transparentize($euiColorInk, .5);
}