Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extended CommonProps in EuiColorPalettePicker palettes types #3616

Merged
merged 5 commits into from
Jun 16, 2020
Merged

Extended CommonProps in EuiColorPalettePicker palettes types #3616

merged 5 commits into from
Jun 16, 2020

Conversation

elizabetdev
Copy link
Contributor

@elizabetdev elizabetdev commented Jun 16, 2020 •
edited
Loading

Summary

Closes #3615.

This PR extendeds CommonProps in EuiColorPalettePickerPaletteTextProps, EuiColorPalettePickerPaletteFixedProps and EuiColorPalettePickerPaletteGradientProps types.

Checklist

  • [ ] Check against all themes for compatibility in both light and dark modes
  • [ ] Checked in mobile
  • [ ] Checked in IE11 and Firefox
  • Props have proper autodocs
  • [ ] Added documentation
  • [ ] Checked Code Sandbox works for the any docs examples
  • Added or updated jest tests
  • [ ] Checked for breaking changes and labeled appropriately
  • [ ] Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@elizabetdev elizabetdev requested review from thompsongl and cchaos June 16, 2020 11:04
@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3616/

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3616/

thompsongl
thompsongl approved these changes Jun 16, 2020
View reviewed changes
Copy link
Contributor

@thompsongl thompsongl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!

cchaos
cchaos approved these changes Jun 16, 2020
View reviewed changes
Copy link
Contributor

@cchaos cchaos left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You probably want to update the PR name, summary and CL item to mention CommonProps now. But other than that, LGTM 👍

@elizabetdev elizabetdev changed the title Added data test subj to EuiColorPalettePicker palettes Extended CommonProps to EuiColorPalettePicker palettes Jun 16, 2020
@elizabetdev elizabetdev changed the title Extended CommonProps to EuiColorPalettePicker palettes Extended CommonProps in EuiColorPalettePicker palettes types Jun 16, 2020
@elizabetdev
Copy link
Contributor Author

jenkins test this

1 similar comment
@elizabetdev
Copy link
Contributor Author

jenkins test this

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3616/

@elizabetdev elizabetdev merged commit cdb64f1 into elastic:master Jun 16, 2020
@thompsongl thompsongl mentioned this pull request Jun 29, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thompsongl thompsongl thompsongl approved these changes

@cchaos cchaos cchaos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

EuiColorPalettePicker palettes prop does not accept data-test-subj
4 participants
@elizabetdev @kibanamachine @cchaos @thompsongl