Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passed buffer as 0 to fix extra gap in EuiSuperSelect #3685

Merged
merged 4 commits into from
Jul 2, 2020
Merged

Passed buffer as 0 to fix extra gap in EuiSuperSelect #3685

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
dfbd932
Passed buffer as 0 to fix extra gap in superselect
shrey Jul 1, 2020
991d0ef
Updated changelog
shrey Jul 1, 2020
966b8dc
Improving changelog
elizabetdev Jul 2, 2020
0ef66b5
Snapshots
elizabetdev Jul 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
- Fixed `EuiSkipLink` interactive props and Safari click issue ([#3665](https://github.com/elastic/eui/pull/3665))
- Fixed `z-index` issues with `EuiHeader`, `EuiFlyout`, and other portal content ([#3655](https://github.com/elastic/eui/pull/3655))
- Fixed `color` prop error in `EuiBadge` to be more flexible with what format it accepts ([#3655](https://github.com/elastic/eui/pull/3655))
- Fixed `EuiSuperSelect` popover from moving 16px horizontally when it's close to a window edge ([#3685](https://github.com/elastic/eui/pull/3685))

**Theme: Amsterdam**

Expand Down
1 change: 1 addition & 0 deletions ...onents/color_picker/color_palette_picker/__snapshots__/color_palette_picker.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -591,6 +591,7 @@ exports[`EuiColorPalettePicker more props are propagated to each option 2`] = `
>
<EuiPopover
anchorPosition="downCenter"
buffer={0}
button={
<EuiSuperSelectControl
className="euiSuperSelect--isOpen__button"
Expand Down
1 change: 1 addition & 0 deletions src/components/form/super_select/__snapshots__/super_select.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -530,6 +530,7 @@ exports[`EuiSuperSelect props more props are propogated to each option 2`] = `
>
<EuiPopover
anchorPosition="downCenter"
buffer={0}
button={
<EuiSuperSelectControl
className="euiSuperSelect--isOpen__button"
Expand Down
3 changes: 2 additions & 1 deletion src/components/form/super_select/super_select.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -339,7 +339,8 @@ export class EuiSuperSelect<T extends string> extends Component<
anchorPosition="downCenter"
ownFocus={false}
popoverRef={this.setPopoverRef}
hasArrow={false}>
hasArrow={false}
buffer={0}>
<EuiScreenReaderOnly>
<p role="alert">
<EuiI18n
Expand Down