Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Playground] EuiRange, EuiDualRange #3938

Merged
merged 5 commits into from
Aug 21, 2020
Merged

[Playground] EuiRange, EuiDualRange #3938

merged 5 commits into from
Aug 21, 2020

Conversation

anishagg17
Copy link
Contributor

Summary

Makes progress on #3057

Checklist

  • Check against all themes for compatibility in both light and dark modes
  • Checked in mobile
  • Checked in Chrome, Safari, Edge, and Firefox
  • Props have proper autodocs
  • Added documentation
  • Checked Code Sandbox works for the any docs examples
  • Added or updated jest tests
  • Checked for breaking changes and labeled appropriately
  • Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@kibanamachine
Copy link

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@thompsongl
Copy link
Contributor

jenkins test this

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3938/

@thompsongl
Copy link
Contributor

This looks out-of-date with master (doesn't have the new docgen info). Can you please update?

@anishagg17
Copy link
Contributor Author

Done .

@thompsongl
Copy link
Contributor

jenkins test this

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3938/

thompsongl
thompsongl reviewed Aug 19, 2020
View reviewed changes
Copy link
Contributor

@thompsongl thompsongl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should set value for both of these. It's easy to get into strange looking configurations if no value is set

@anishagg17 anishagg17 requested a review from thompsongl August 20, 2020 11:32
@thompsongl
Copy link
Contributor

jenkins test this

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3938/

thompsongl
thompsongl suggested changes Aug 20, 2020
View reviewed changes
Copy link
Contributor

@thompsongl thompsongl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticed that when toggling on showTicks the range disappears and errors are logged in the console.
When showTicks is on, can we also change the tickInterval prop to 10?

@anishagg17
Copy link
Contributor Author

Noticed that when toggling on showTicks the range disappears and errors are logged in the console.

It occurs because tickInterval is set to undefined,

When showTicks is on, can we also change the tickInterval prop to 10?

We should follow the pattern as in EuiBadge by highlighting the tickInterval input with the error.

@thompsongl
Copy link
Contributor

We should follow the pattern as in EuiBadge by highlighting the tickInterval input with the error.

That works for me 👍

@anishagg17 anishagg17 requested a review from thompsongl August 20, 2020 22:14
@thompsongl
Copy link
Contributor

jenkins test this

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3938/

thompsongl
thompsongl approved these changes Aug 21, 2020
View reviewed changes
Copy link
Contributor

@thompsongl thompsongl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error message looks good

@thompsongl thompsongl merged commit c404e43 into elastic:master Aug 21, 2020
@anishagg17 anishagg17 deleted the play_range branch August 21, 2020 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thompsongl thompsongl thompsongl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anishagg17 @kibanamachine @thompsongl