Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

table-layout: fixed. Remove 20px max-width #398

Merged
merged 2 commits into from
Feb 14, 2018
Merged

table-layout: fixed. Remove 20px max-width #398

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
40ea703
table fixed for less problems
snide Feb 13, 2018
9e2fe52
changelog
snide Feb 14, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@

**Bug fixes**

- Tables now default to `table-layout: fixed` to avoid some collapsing cell problems. [#398](https://github.com/elastic/eui/pull/398)
- Wrap long lines of text within the body of `EuiToast` instead of letting text overflow ([#392](https://github.com/elastic/eui/pull/392))
- Fix dark theme coloring of Substeps ([#396](https://github.com/elastic/eui/pull/396))
- Reorder selectors to fix fixed progress bar in Firefox ([#404](https://github.com/elastic/eui/pull/404))
Expand Down
4 changes: 0 additions & 4 deletions src/components/table/_index.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,4 @@
/**
* 1. Prevent cells from expanding based on content size. This substitutes for table-layout: fixed.
*/
@mixin euiTableCell {
max-width: 20px; /* 1 */
vertical-align: middle;
}

Expand Down
1 change: 1 addition & 0 deletions src/components/table/_table.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
@include euiFontSizeS;

width: 100%;
table-layout: fixed;
border: none;
border-collapse: collapse;
background-color: $euiColorEmptyShade;
Expand Down