Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EuiInMemoryTable] Added ability to insert component between the searchbar and the table #4103

Merged
merged 9 commits into from
Oct 5, 2020
Merged

[EuiInMemoryTable] Added ability to insert component between the searchbar and the table #4103

merged 9 commits into from
Oct 5, 2020

Conversation

ashikmeerankutty
Copy link
Contributor

@ashikmeerankutty ashikmeerankutty commented Oct 3, 2020 •
edited
Loading

Summary

Fixes #4095

  • Added a prop childrenBetween to add components between search bar and table
  • Added tests

Checklist

  • Check against all themes for compatibility in both light and dark modes
  • Checked in mobile
  • Checked in Chrome, Safari, Edge, and Firefox
  • Props have proper autodocs
    - [ ] Added documentation
    - [ ] Checked Code Sandbox works for the any docs examples
  • Added or updated jest tests
  • Checked for breaking changes and labeled appropriately
  • Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@kibanamachine
Copy link

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@andreadelrio
Copy link
Contributor

jenkins test this

@andreadelrio
Copy link
Contributor

@ashikmeerankutty thanks for taking this one on Ashik. How about updating the docs to show a use case for this new prop? Could maybe be an extra switch here, something like "Content between"

image

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_4103/

@ashikmeerankutty
Copy link
Contributor Author

@andreadelrio Thank you for your suggestion. Added an example usage for the new prop. Can you please verify ?.

andreadelrio
andreadelrio requested changes Oct 4, 2020
View reviewed changes
Copy link
Contributor

@andreadelrio andreadelrio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ashikmeerankutty thanks for adding the example. Sending one suggestion to improve it.

src/components/basic_table/in_memory_table.tsx Outdated Show resolved Hide resolved
src-docs/src/views/tables/in_memory/in_memory_search.js Outdated Show resolved Hide resolved
andreadelrio
andreadelrio approved these changes Oct 5, 2020
View reviewed changes
Copy link
Contributor

@andreadelrio andreadelrio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chandlerprall
Copy link
Contributor

jenkins test this

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_4103/

chandlerprall
chandlerprall suggested changes Oct 5, 2020
View reviewed changes
Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small request, otherwise this looks great!

src/components/basic_table/in_memory_table.tsx Outdated Show resolved Hide resolved
chandlerprall
chandlerprall approved these changes Oct 5, 2020
View reviewed changes
Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Pulled & tested locally. Thanks again @ashikmeerankutty !

@chandlerprall chandlerprall merged commit 7fc59b6 into elastic:master Oct 5, 2020
@chandlerprall chandlerprall mentioned this pull request Oct 15, 2020
Merged
This was referenced Nov 9, 2020
Merged
Closed
kshitij86 added a commit to kshitij86/eui that referenced this pull request Nov 29, 2020
@kshitij86
[EuiInMemoryTable] Added ability to insert component between the sear…
75ca7fd 
…chbar and the table (elastic#4103)

* Added childrenBetween prop

* Add test for children between search and table

* Updated snapshots

* Updated comment for prop

* Added cl

* Add docs example for children between

* Fixed a typo

* Fixed text

* Fixed issue when value is 0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreadelrio andreadelrio andreadelrio approved these changes

@chandlerprall chandlerprall chandlerprall approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[EuiInMemoryTable] Add the ability to inject arbitrary content between the searchbar and the table
4 participants
@ashikmeerankutty @kibanamachine @andreadelrio @chandlerprall