Major version dependency upgrades, pt. IV #4112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thompsongl
commented
Oct 5, 2020
| @@ -1,4 +1,6 @@ | |||
| { | |||
| "root": true, | |||
There was a problem hiding this comment.
Prevents eslint from attempting to read this config from EUI root
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4112/ |
chandlerprall
suggested changes
Oct 6, 2020
This reverts commit 745d9a0.
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4112/ |
chandlerprall
approved these changes
Oct 6, 2020
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4112/ |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4112/ |
|
Will wait to merge until after the next release to avoid excessive conflicts in open PRs, possibly closer to the weekend |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4112/ |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4112/ |
kshitij86
added a commit
to kshitij86/eui
that referenced
this pull request
Nov 29, 2020
* eslint; prettier * react-datepicker eslint * prettier autofix * more eslint * CL * Revert "CL" This reverts commit 745d9a0. * lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Partial resolution of #3969:
eslint&prettierThe only change of note is the default configuration update for
prettier, which now requires that all arrow functions have parentheses around single parameters. We've decided to use the new default value, largely because of type annotations.Checklist
- [ ] Check against all themes for compatibility in both light and dark modes- [ ] Checked in mobile- [ ] Checked in Chrome, Safari, Edge, and Firefox- [ ] Props have proper autodocs- [ ] Added documentation- [ ] Checked Code Sandbox works for the any docs examples- [ ] Added or updated jest tests- [ ] Checked for accessibility including keyboard-only and screenreader modes- [ ] A changelog entry exists and is marked appropriately