-
Notifications
You must be signed in to change notification settings - Fork 842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update TypeScript to v4 #4296
Update TypeScript to v4 #4296
Conversation
Preview documentation changes for this PR: https://eui.elastic.co/pr_4296/ |
Preview documentation changes for this PR: https://eui.elastic.co/pr_4296/ |
Preview documentation changes for this PR: https://eui.elastic.co/pr_4296/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A number of the yarn.lock changes add a second package installation instead of upgrading the existing ones.
Otherwise this looks good 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Preview documentation changes for this PR: https://eui.elastic.co/pr_4296/ |
jenkins test this flaky tooltip test |
Preview documentation changes for this PR: https://eui.elastic.co/pr_4296/ |
Summary
Updates TypeScript to v4.0.5.
Tested in Kibana without issue. v4.1.x is our real target, but we need to wait for cloud-ui to update, plus taking that next step presents some as-of-yet unsolved challenges. This is an intermediate jump.
Gets at #3969
Checklist
- [ ] Check against all themes for compatibility in both light and dark modes- [ ] Checked in mobile- [ ] Checked in Chrome, Safari, Edge, and Firefox- [ ] Added documentation- [ ] Added or updated jest tests- [ ] Checked for accessibility including keyboard-only and screenreader modes