Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TypeScript to v4 #4296

Merged
merged 5 commits into from
Dec 15, 2020
Merged

Update TypeScript to v4 #4296

merged 5 commits into from
Dec 15, 2020

Conversation

thompsongl
Copy link
Contributor

@thompsongl thompsongl commented Nov 20, 2020

Summary

Updates TypeScript to v4.0.5.
Tested in Kibana without issue. v4.1.x is our real target, but we need to wait for cloud-ui to update, plus taking that next step presents some as-of-yet unsolved challenges. This is an intermediate jump.

Gets at #3969

Checklist

- [ ] Check against all themes for compatibility in both light and dark modes
- [ ] Checked in mobile
- [ ] Checked in Chrome, Safari, Edge, and Firefox

  • Props have proper autodocs

- [ ] Added documentation

- [ ] Added or updated jest tests

  • Checked for breaking changes and labeled appropriately

- [ ] Checked for accessibility including keyboard-only and screenreader modes

  • A changelog entry exists and is marked appropriately

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_4296/

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_4296/

@thompsongl thompsongl marked this pull request as ready for review November 20, 2020 20:33
@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_4296/

Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A number of the yarn.lock changes add a second package installation instead of upgrading the existing ones.

Otherwise this looks good 👍

Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_4296/

@thompsongl
Copy link
Contributor Author

jenkins test this

flaky tooltip test

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_4296/

@chandlerprall chandlerprall merged commit c7749b1 into elastic:master Dec 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants