Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error stemming from selected prop on EuiSelect #436

Merged
merged 2 commits into from
Feb 23, 2018

Conversation

cchaos
Copy link
Contributor

@cchaos cchaos commented Feb 22, 2018

Apparently React doesn’t use this property and uses value/defaultValue similar to other inputs.

@cchaos cchaos added the bug label Feb 22, 2018
@cchaos cchaos requested a review from cjcenizal February 23, 2018 18:17
Copy link
Contributor

@cjcenizal cjcenizal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cchaos added 2 commits February 23, 2018 15:18
Apparently React doesn’t use this property and uses `value`/`defaultValue` similar to other inputs.
@cchaos cchaos force-pushed the fix-select-first-item branch from c24aa64 to d9e81ec Compare February 23, 2018 20:18
@cchaos cchaos merged commit f96bba2 into elastic:master Feb 23, 2018
@cchaos cchaos deleted the fix-select-first-item branch February 23, 2018 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants