[EuiPopover] Initial isOpen works with outside click #4461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jenkins test this |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4461/ |
|
jenkins test this |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4461/ |
|
Test failures are due to axe. The open popover prevents axe from traversing the page correctly. Will be resolved when I revert the 'revert me' docs commit. |
chandlerprall
approved these changes
Feb 3, 2021
💯
Sure thing |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4461/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4460, in which initializing EuiPopover with
isOpen=truewould never setstate.isOpenStable=trueand therefore disable EuiOutsideClickDetector.Previously,
componentDidUpdatewas the only place thatstate.isOpenStablewas set totrue. This moves the open popover logic outside ofcomponentDidUpdateto a standalone function (onOpenPopover), which can now be called duringcomponentDidMount.The simpler way would just be set
state.isOpenStableduringcomponentDidMount, but that would bypass all timing functions. I could be persuaded that this simpler path is better, though.Also, setting
isOpening: trueis no longer necessary incomponentDidMount, but the Jest environment misses the update and causes tests and snapshots to break.Checklist
- [ ] Check against all themes for compatibility in both light and dark modes- [ ] Checked in mobile- [ ] Checked in Chrome, Safari, Edge, and Firefox- [ ] Props have proper autodocs and playground toggles- [ ] Added documentation- [ ] Added or updated jest tests- [ ] Checked for accessibility including keyboard-only and screenreader modes