[EuiBadge] Add button type to prevent form submission #4479
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4273 by adding
type=button
to the "remove" button on the EuiBadge items rendered by EuiComboBox.The problem comes from the default button
type=submit
being triggered when Enter was hit on an input element in a form withonSubmit
/action
.This is half true. The combobox should indeed not react, but the form should not submit without a
type=submit
element in the form. The spec says that in a form with no submit buttons, implicit submission will be done if only one input is present.So you can see in the to-be-reverted docs change that the combobox no longer steals focus, but the form will not be submitted without uncommenting the submit input.
Checklist
- [ ] Check against all themes for compatibility in both light and dark modes- [ ] Checked in mobile- [ ] Props have proper autodocs and playground toggles- [ ] Added documentation- [ ] Added or updated jest tests