Added labelProps prop to [EuiSwitch, EuiRadio, EuiCheckbox]
#4516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
cchaos
suggested changes
Feb 12, 2021
cchaos
suggested changes
Feb 15, 2021
| @@ -56,6 +57,10 @@ export type EuiSwitchProps = CommonProps & | |||
| disabled?: boolean; | |||
| compressed?: boolean; | |||
| type?: 'submit' | 'reset' | 'button'; | |||
| /** | |||
| * Object of props passed to the <span/> | |||
There was a problem hiding this comment.
Suggested change
| * Object of props passed to the <span/> | |
| * Object of props passed to the label's <span/> |
akashgp09
force-pushed
the
Form-controls
branch
from
a9e1336 to
f4dfffd
Compare
cchaos
suggested changes
Feb 17, 2021
cchaos
approved these changes
Feb 18, 2021
|
Jenkins, test this |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4516/ |
Jenkins, test this |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4516/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR Fixes #3660
Added
labelPropsprop to EuiSwitch, EuiRadio and EuiCheckbox.Checklist
- [ ] Added documentation- [ ] Checked Code Sandbox works for the any docs examples- [ ] Added or updated jest tests- [ ] Checked for breaking changes and labeled appropriately- [ ] Checked for accessibility including keyboard-only and screenreader modes