-
Notifications
You must be signed in to change notification settings - Fork 842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EuiDualRange] Draggable highlight area #4776
Conversation
@myasonik @miukimiu Calling on your expertise to help make the right decisions for a11y and any design states that I may not have accounted for. Just high-level things right now while in draft mode. @nreese Take a look and see if this fits the bill for your time slider. Note in the summary I've called out some things I'm still working on. |
Preview documentation changes for this PR: https://eui.elastic.co/pr_4776/ |
This is a great addition, thanks for adding this feature. It works just as expected and will make the timeslider some much easier to use. |
@thompsongl this new feature is looking great. 🎉 I've been testing other range sliders, and one thing that I noticed is the use of mouse cursors. Right now, we're using
So should we be using
Is there a better name than
|
Thanks, @miukimiu; this all makes sense to me. I'll try out some cursor change ideas. |
Preview documentation changes for this PR: https://eui.elastic.co/pr_4776/ |
I looked into this, and I think the answer is no. |
Preview documentation changes for this PR: https://eui.elastic.co/pr_4776/ |
Still looking at this. Two things in particular: 1) decimal (less than 1) |
Preview documentation changes for this PR: https://eui.elastic.co/pr_4776/ |
Preview documentation changes for this PR: https://eui.elastic.co/pr_4776/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @thompsongl.
Tested in Chrome, Safari, Edge, and Firefox and works perfectly. 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few nits but nothing major 🚀
Preview documentation changes for this PR: https://eui.elastic.co/pr_4776/ |
Preview documentation changes for this PR: https://eui.elastic.co/pr_4776/ |
Preview documentation changes for this PR: https://eui.elastic.co/pr_4776/ |
Preview documentation changes for this PR: https://eui.elastic.co/pr_4776/ |
Summary
Closes #4694
Opening for early review. I still need to fine tune the dragging and accommodate decimal and non-standardstep
values (only really works with1
at present).Second example in the "Dual range" section has
isDraggable
enabled.Adds a draggable highlight area between the two range slider values in EuiDualRange. It is optional and currently off by default. Movement works/feel good for small
step
values (i.e., a large number of steps in the range), but largerstep
values (i.e., a small number of steps in the range) makes the drag interaction feel a bit disjointed; looking for thoughts on interaction improvement or suggestions for guidance documentation.Also moved some global services out of
color_picker/utils.ts
and intoservices/
Checklist
- [ ] Checked in mobile