Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiPopover] Fixed the z-index #4818

Closed
wants to merge 2 commits into from

Conversation

hetanthakkar
Copy link
Contributor

@hetanthakkar hetanthakkar commented May 20, 2021

Summary

Fixed issue #4756

Checklist

  • Check against all themes for compatibility in both light and dark modes
  • Checked in mobile
  • Checked in Chrome, Safari, Edge, and Firefox
  • Props have proper autodocs and playground toggles
  • Added documentation
  • Checked Code Sandbox works for the any docs examples
  • Added or updated jest tests
  • Checked for breaking changes and labeled appropriately
  • Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@kibanamachine
Copy link

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@hetanthakkar
Copy link
Contributor Author

hetanthakkar commented May 20, 2021

The z-index of header is 1000 so I set the z-index of EuiPopver to be 999 instead of 2000

@elizabetdev elizabetdev changed the title Fixed the z-index of EuiPopver [EuiPopover] Fixed the z-index May 24, 2021
@elizabetdev
Copy link
Contributor

jenkins test this

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_4818/

@elizabetdev
Copy link
Contributor

Hi @hetanthakkar1,

Thanks for opening this PR but the EuiPopover should have a higher z-index than the EuiHeader or we might end up with this type of issue: #3398.

In some situations the popover might be too close to the top of the page and then it's impossible to read the content because the header (if fixed) can cover it.

So this "fix" can introduce a lot of issues and for this reason, I'm closing the PR. I guess issue #4756 shouldn't have been marked as a bug. Visually it looks like a bug but after some thought, it's not. 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants