Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiSideNav] Made mobileBreakpoints optional #4921

Merged
merged 5 commits into from
Jun 24, 2021

Conversation

cchaos
Copy link
Contributor

@cchaos cchaos commented Jun 24, 2021

Fixes #4919

Also quickly allows for a non-responsive version by setting to undefined.

Checklist

  • [ ] Check against all themes for compatibility in both light and dark modes
  • [ ] Checked in mobile
  • [ ] Checked in Chrome, Safari, Edge, and Firefox
  • Props have proper autodocs and playground toggles
  • [ ] Added documentation
  • [ ] Checked Code Sandbox works for the any docs examples
  • Added or updated jest tests
  • [ ] Checked for breaking changes and labeled appropriately
  • [ ] Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@cchaos cchaos requested a review from thompsongl June 24, 2021 15:28
Copy link
Contributor

@thompsongl thompsongl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦑

@thompsongl
Copy link
Contributor

Not sure why ^ was necessary 🤷‍♂️

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_4921/

@thompsongl thompsongl merged commit 90a667d into elastic:master Jun 24, 2021
@cchaos cchaos deleted the fix/sidenav_mobileProp branch June 24, 2021 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[EuiSideNav] mobileBreakpoints should be optional
3 participants