[EuiSuperDatePicker] & [EuiButtonIcon] A couple quick fixes #5060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
August 20, 2021 11:20
Which in turn fixes EuiPagination left/right arrows, and EuiListGroupItem extra action
cchaos
changed the title
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5060/ |
snide
approved these changes
Aug 20, 2021
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5060/ |
|
Looks like a prettier error in |
|
Might have been from a previous PR where I added that. For some reason Prettier has just completely stopped working on that page in my IDE. I wonder if there's some exclusion that's including this file because it contains the work |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5060/ |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5060/ |
chandlerprall
approved these changes
Aug 23, 2021
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5060/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EuiSuperDatePicker
While I had been checking the EuiSuperDatePicker's use of EuiDatePicker during #5000, I must have missed a final pass and saw that the width wasn't growing. So this is now fixed.
Before
After
Also fixed the responsive sizes:
Before
After
EuiButtonIcon
While I was testing #5054 in Kibana, I noticed that the filter in/out buttons were sometimes "disabled" but were still
bluewith pointer events.I realized that EuiButtonIcon only afforded for
isDisabledeven thoughdisabledwas also a valid prop because ofPropsForButton. And whiledisabledwas still being applied to the rendered DOM element, the styling was not updated to get--isDisabledclass.Before:
**After: **
So now it checks for
disabledas well to apply the class which apparently also fixes some internal usages of justdisabledon EuiButtonIcon within EuiPagination and EuiListGroupItem.Checklist
[ ] Props have proper autodocs and playground toggles[ ] Checked Code Sandbox works for the any docs examples[ ] Checked for breaking changes and labeled appropriately[ ] Checked for accessibility including keyboard-only and screenreader modes