Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make <EuiProgress> props more specific #518

Merged
merged 2 commits into from
Mar 19, 2018
Merged

Make <EuiProgress> props more specific #518

merged 2 commits into from
Mar 19, 2018

Conversation

weltenwort
Copy link
Member

@weltenwort weltenwort commented Mar 15, 2018 •
edited
Loading

This PR updates the <EuiProgress> TypeScript types to intersect with ProgressHTMLAttributes instead of just HTMLAttributes, which adds correct types for the value and max props.

@weltenwort weltenwort self-assigned this Mar 15, 2018
@weltenwort weltenwort force-pushed the enhancement-ts-types-progress branch from 0861779 to 40cb3f5 Compare March 15, 2018 11:54
@weltenwort weltenwort requested a review from uboness March 15, 2018 11:55
@weltenwort weltenwort merged commit 37bc86c into elastic:master Mar 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uboness uboness uboness approved these changes

Assignees

@weltenwort weltenwort

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@weltenwort @uboness