-
Notifications
You must be signed in to change notification settings - Fork 841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EuiButtonGroup] Add title
when in iconOnly
mode
#5199
Conversation
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
💚 CLA has been signed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 Thanks for the PR @lejara !!
Would you please sign the CLA linked below if you have not done so already. Be sure to use the same email address linked to your Github account.
Thanks for the update. I'll get our CI (Jenkins) started for you which will run our tests and get a preview built. Jenkins, test this |
Preview documentation changes for this PR: https://eui.elastic.co/pr_5199/ |
Flakey test. Jenkins, test this |
Preview documentation changes for this PR: https://eui.elastic.co/pr_5199/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>
jenkins test this |
Preview documentation changes for this PR: https://eui.elastic.co/pr_5199/ |
Summary
Fixes (#5180)
Checklist
[ ] Check against all themes for compatibility in both light and dark modes[ ] Checked in mobile[ ] Props have proper autodocs and playground toggles[ ] Added documentation[ ] Checked Code Sandbox works for any docs examples[] Added or updated jest tests[ ] Checked for breaking changes and labeled appropriately[ ] Checked for accessibility including keyboard-only and screenreader modes