[Docs] Separated out Borders to its own page & [EuiTableRowCell] fixes #5283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 19 commits
September 29, 2021 15:37
…n JS or Sass theming language
…on in docs rather that sass-loader
This reverts commit f3eccfb.
…rgb`" This reverts commit 2db22a4.
…_setup_and_breakpoints
…_border # Conflicts: # src-docs/src/components/with_theme/theme_context.tsx # src-docs/src/routes.js # src-docs/src/views/theme/_breakpoints.js # src-docs/src/views/theme/_components/_theme_values_table.tsx # src-docs/src/views/theme/_json/_get_json_vars.js # src-docs/src/views/theme/_json/eui_theme_dark.json # src-docs/src/views/theme/_json/eui_theme_light.json # src-docs/src/views/theme/breakpoints/_breakpoints_js.tsx # src-docs/src/views/theme/breakpoints/breakpoints.tsx
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5283/ |
cchaos
changed the title
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5283/ |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5283/ |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5283/ |
elizabetdev
approved these changes
Oct 20, 2021
There was a problem hiding this comment.
LGTM! 🎉
Tested in Chrome, Safari, Edge and, Firefox.
A minor thing. I noticed that all the hex colors for CSS-in-JS are in uppercase:
For Sass they're in lowercase:
In the "Global values" page, the hex values are also in uppercase:
But in "Theme provider" page they're in lowercase:
Should we only stick to one letter case? If I had to choose I would prefer the lowercase. I think it has better readability.
|
Thank for catching that @miukimiu. I agree we should be consistent. Since this PR doesn't introduce the inconsistency itself and is most likely a manner of checking through all the methods of importing our styles, I've moved it to a separate issue. #5287 |
thompsongl
reviewed
Oct 20, 2021
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5283/ |
thompsongl
approved these changes
Oct 20, 2021
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5283/ |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5283/ |
chandlerprall
pushed a commit
to chandlerprall/eui
that referenced
this pull request
Oct 26, 2021
elastic#5283) * Moved Border tokens to its own page * Figured out a way to get subsections in the sidenav working * Added the new `_values` under `customizing/` * [EuiTableRowCell] Actually support `valign` property manually * [EuiTable*] Fixing some props and mobile options * Slightly better responsive table styles
ym
pushed a commit
to ym/eui
that referenced
this pull request
Oct 29, 2021
elastic#5283) * Moved Border tokens to its own page * Figured out a way to get subsections in the sidenav working * Added the new `_values` under `customizing/` * [EuiTableRowCell] Actually support `valign` property manually * [EuiTable*] Fixing some props and mobile options * Slightly better responsive table styles
chandlerprall
added a commit
that referenced
this pull request
Nov 5, 2021
* Provide rows for datagrid cells to be owned by * changelog * undoing things * working except virtualized container * working row wrapper implementation * Create datagrid row elements on-demand and render cells via portals * Provide rows for datagrid cells to be owned by * changelog * undoing things * working except virtualized container * working row wrapper implementation * Create datagrid row elements on-demand and render cells via portals * Small style cleanup * updated changelog * fixing a bad changelog merge * oh that style was important * Update src/components/datagrid/body/data_grid_row_manager.ts Co-authored-by: Constance <constancecchen@users.noreply.github.com> * Update src/components/datagrid/data_grid_types.ts Co-authored-by: Constance <constancecchen@users.noreply.github.com> * Ensure unique ID in combobox with prepended or appended labels (#5229) * Making an explicit check for ID prop in EUI Combobox * Checking for a user-passed ID prop * If no user-passed ID, we'll use the `rootId()` class method to set one * Prepend and append props need an ID to relate label to the input * Adding example for Combobox with prepended label * Confirmed the label `for` attribute is referencing input `id` * Added styles to round the edges of the child `<div>` when we prepend a label * Bumped package.json * Adding CHANGELOG entry and bumping version * Update combo_box.tsx * Updating styles to match other forms with prepend and apppend. * Finishing Combobox CSS and test updates * Simplified the Amsterdam overrides for prepended / appended labels * Added conditional classes to `combo_box.tsx` * Added unit tests for user passed ID, prepended and appended classes * Reordering props in child component. * Final adjustment to ID check in ComboBox * Final updates to styling and documentation * Added CSS rules for compressed, prepend and append border radius * Updated the Display Toggles to include append * Removed a duplicated instruction paragraph * Simplified the logic for a unique ID in combobox.ts * Adding Combobox unique ID to master changelog * Updated Form Control Layout SCSS * The borders were still rounded with prepend and append enabled * Added two more rules to make borders square for full height and compressed * Move to _combo_box.scss Co-authored-by: cchaos <caroline.horn@elastic.co> * update i18ntokens * 40.0.0 * Updated documentation. * Add combined Jest+Cypress code coverage reports (#5262) * Install Cypress code coverage dependencies * Set up required babel+istanbul config * Set up Cypress code coverage config @see https://github.com/cypress-io/code-coverage#instrument-unit-tests * Add script for combining cypress & jest code coverage -into a single json & html report * Misc cleanup/ignores - Ignore new `.nyc_output` dir generated by cypress/istanbul - Improve Jest config collectCoverageFrom !ignores: - DRY out component+services folder patterns with a {,} glob - Ignore new Cypress .spec files and .testenv files for jest coverage - eslintignore the cypress folder, since they're all .js anyway and it has a decent amount of idiosyncracies + cleanup unused eslint-disable + cleanup cypress comment boilerplate + remove unused paths from webpack config * Add wiki documentation * [PR feedback] Move nyc config to own file * [PR feedback] Switch combine coverage script to .sh * [EuiMarkdownEditor] Add `remark-breaks` and line break plugin (#5272) * Add remark-breaks and line break plugin to MarkdownEditor * Update changelog * [Docs] Separated out Borders to its own page & [EuiTableRowCell] fixes (#5283) * Moved Border tokens to its own page * Figured out a way to get subsections in the sidenav working * Added the new `_values` under `customizing/` * [EuiTableRowCell] Actually support `valign` property manually * [EuiTable*] Fixing some props and mobile options * Slightly better responsive table styles * Fix CL from #5272 * [Docs] Update EuiDatePicker types (#5318) * omit unsupported types * resolve console errors * CL * [Cypress] Add flakey test retries + harden intermittent context menu failures (#5317) * Add Cypress failed test retries to CI run mode * Increase cy.wait on flaky context menu tests (just in case) * More hardening * [Docs] Fix Colors guidelines (#5316) * use useJsonVars * use variable * Update dependency @elastic/charts to ^38.1.0 (#5321) * PR feedback * Added a cypress test for datagrid row rendering * Revert changes(?) to docs/ * revert changelog reformats * re-ignore a couple datagrid example pages when running a11y tests * Alternate way to know if the datagrid cells have rendered * PR feedback * changelog Co-authored-by: Constance <constancecchen@users.noreply.github.com> Co-authored-by: Trevor Pierce <1Copenut@users.noreply.github.com> Co-authored-by: cchaos <caroline.horn@elastic.co> Co-authored-by: ian moersen <ian@union.io> Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com> Co-authored-by: Greg Thompson <thompson.glowe@gmail.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Borders
Now exists as its own page with a nice breakdown in the side nav.
EuiTableRowCell now actually supports
valignI noticed that we automatically get this prop by inheriting from the DOM element, but when applied it never override our own custom
vertical-alignCSS property. So I've not consumed this prop's value and applied it as a class to support "all" the values.Also fixed some deprecated prop comments & inheritance as well as:
mobileOptions.enlargestyling in AmsterdammobileOptions.truncateTextfrom getting overridden bytruncateTextChecklist
[ ] Checked Code Sandbox works for any docs examples[ ] Checked for breaking changes and labeled appropriately[ ] Checked for accessibility including keyboard-only and screenreader modes