-
Notifications
You must be signed in to change notification settings - Fork 841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Docs] Separated out Typography to its own page #5300
Conversation
…n JS or Sass theming language
…on in docs rather that sass-loader
This reverts commit f3eccfb.
…rgb`" This reverts commit 2db22a4.
…_setup_and_breakpoints
…_typography # Conflicts: # src-docs/src/components/with_theme/theme_context.tsx # src-docs/src/routes.js # src-docs/src/views/guidelines/sass.js # src-docs/src/views/theme/_components/_theme_values_table.tsx # src-docs/src/views/theme/_json/_get_json_vars.js # src-docs/src/views/theme/_json/eui_theme_dark.json # src-docs/src/views/theme/_json/eui_theme_light.json # src-docs/src/views/theme/borders/_border_js.tsx # src-docs/src/views/theme/breakpoints/_breakpoints_js.tsx # src-docs/src/views/theme/breakpoints/breakpoints.tsx # src-docs/src/views/theme/customizing/_border.js # src-docs/src/views/theme/customizing/_breakpoints.js # src-docs/src/views/theme/values.js
Preview documentation changes for this PR: https://eui.elastic.co/pr_5300/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's looking good. 😎
But I noticed there's not a section for font scale when the language selector is set to CSS-in-JS. Is it something you're planning to add?
Preview documentation changes for this PR: https://eui.elastic.co/pr_5300/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Confirmed Elizabet's requests were resolved
Preview documentation changes for this PR: https://eui.elastic.co/pr_5300/ |
* Added Typography page * Deleting all old Sass typography
Simply just docs in this one
Checklist
[ ] Props have proper autodocs and playground toggles[ ] Checked Code Sandbox works for any docs examples[ ] Added or updated jest and cypress tests[ ] Checked for breaking changes and labeled appropriately[ ] A changelog entry exists and is marked appropriately