Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Separated out Typography to its own page #5300

Merged
merged 30 commits into from
Oct 26, 2021

Conversation

cchaos
Copy link
Contributor

@cchaos cchaos commented Oct 20, 2021

Simply just docs in this one

Screen Shot 2021-10-20 at 17 44 32 PM

Checklist

  • Check against all themes for compatibility in both light and dark modes
  • Checked in mobile
  • Checked in Chrome, Safari, Edge, and Firefox
  • [ ] Props have proper autodocs and playground toggles
  • Added documentation
  • [ ] Checked Code Sandbox works for any docs examples
  • [ ] Added or updated jest and cypress tests
  • [ ] Checked for breaking changes and labeled appropriately
  • Checked for accessibility including keyboard-only and screenreader modes
  • [ ] A changelog entry exists and is marked appropriately

cchaos added 25 commits September 29, 2021 15:37
…_typography

# Conflicts:
#	src-docs/src/components/with_theme/theme_context.tsx
#	src-docs/src/routes.js
#	src-docs/src/views/guidelines/sass.js
#	src-docs/src/views/theme/_components/_theme_values_table.tsx
#	src-docs/src/views/theme/_json/_get_json_vars.js
#	src-docs/src/views/theme/_json/eui_theme_dark.json
#	src-docs/src/views/theme/_json/eui_theme_light.json
#	src-docs/src/views/theme/borders/_border_js.tsx
#	src-docs/src/views/theme/breakpoints/_breakpoints_js.tsx
#	src-docs/src/views/theme/breakpoints/breakpoints.tsx
#	src-docs/src/views/theme/customizing/_border.js
#	src-docs/src/views/theme/customizing/_breakpoints.js
#	src-docs/src/views/theme/values.js
@cchaos cchaos added documentation Issues or PRs that only affect documentation - will not need changelog entries skip-changelog labels Oct 20, 2021
@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_5300/

@elizabetdev elizabetdev self-requested a review October 26, 2021 11:01
Copy link
Contributor

@elizabetdev elizabetdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's looking good. 😎

But I noticed there's not a section for font scale when the language selector is set to CSS-in-JS. Is it something you're planning to add?

src-docs/src/views/theme/typography/_typography_js.tsx Outdated Show resolved Hide resolved
@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_5300/

Copy link
Contributor

@thompsongl thompsongl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
Confirmed Elizabet's requests were resolved

@cchaos cchaos enabled auto-merge (squash) October 26, 2021 21:13
@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_5300/

@cchaos cchaos merged commit d44d2dd into elastic:master Oct 26, 2021
@cchaos cchaos deleted the theme_languages/3_typography branch October 26, 2021 21:55
ym pushed a commit to ym/eui that referenced this pull request Oct 29, 2021
* Added Typography page
* Deleting all old Sass typography
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Issues or PRs that only affect documentation - will not need changelog entries skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants