-
Notifications
You must be signed in to change notification settings - Fork 841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exclude mocks and Cypress specs from eui.d.ts #5412
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed locally that eui.d.ts
does not contain any mock
or spec
files (and therefore no jest
), and compared to main
which does have mock
file references.
You could use the upgrade PR branch and just replace the |
I can confirm that on latest On this branch when I run |
Haha, Greg's 2 fast and 2 furious |
Bootstrapping the upgrade PR branch now, may take a while. If we're confident this works and would rather start the patch release process now I'm good with it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Edit: beat by Greg! ❤️
Confirmed mentions of mock
are gone from eui.d.ts after running the dtsgenerator script. Spot checked the ts+tsx->{ts,tsx} format change works as intended.
Test against local Kibana somehow before patch release??
For this I usually copy & paste the generated eui.d.ts into Kibana's node_modules/@elastic/eui/eui.d.ts and run the type checker.
Preview documentation changes for this PR: https://eui.elastic.co/pr_5412/ |
OK, pasted (Unrelated: I saw type failures related to my |
Summary
Per @1Copenut's upgrade Kibana PR (elastic/kibana#119205), the checks step is failing with this error:
Mocks should not be exported in our
eui.d.ts
file, nor should any other test files. I've updated ourdtsgenerator.js
config to exclude all possible mocks, as well as Cypress spec files just in case.Checklist