[EuiRange] Remove tick label scrollbars in Safari #5427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cee-chen
reviewed
Dec 1, 2021
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5427/ |
cee-chen
approved these changes
Dec 1, 2021
Co-authored-by: Constance <constancecchen@users.noreply.github.com>
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5427/ |
elizabetdev
approved these changes
Dec 2, 2021
There was a problem hiding this comment.
Thanks @thompsongl! I tested in Safari with System Preferences > General > Show scrollbars and LGTM! 🎉
I also tested in Firefox and Chrome.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #5425 by adding
overflow-y: hidden;to the tick label elements.Note that this bug only affects Safari, and is really only noticeable when system scrollbars are configured to show "Always" (System Preferences > General > Show scrollbars)
overflow: hidden;was not used because we overrideoverflow-xin the case of custom labels.Pink: Desired label truncation
Orange: Desired label overflow
Checklist
- [ ] Props have proper autodocs and playground toggles- [ ] Added documentation- [ ] Checked Code Sandbox works for any docs examples- [ ] Added or updated jest and cypress tests