Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Global reset] Fix reset of button styles #5452

Merged
merged 2 commits into from
Dec 7, 2021

Conversation

cchaos
Copy link
Contributor

@cchaos cchaos commented Dec 7, 2021

I noticed that the font-size of the links in our Props docs table were way too big and found that I was originally too heavy-handed with the new global styles for Emotion. Previously, it just set everything to inherit, while in the new file I applied our actual font styles. This broke the EuiLink font-size inheritance if the link was actually a <button> and rendered inside of a sized EuiText block.

Before
Screen Shot 2021-12-07 at 10 58 28 AM

After
Screen Shot 2021-12-07 at 10 58 39 AM

This PR pulls that button selector out of the input-specific font global styles and just applies the necessary font-family. It also ensure font-size inheritance by adding it to the reset file.

Checklist

  • Check against all themes for compatibility in both light and dark modes
  • Checked in mobile
  • Checked in Chrome, Safari, Edge, and Firefox
  • [ ] Props have proper autodocs and playground toggles
  • [ ] Added documentation
  • [ ] Checked Code Sandbox works for any docs examples
  • [ ] Added or updated jest and cypress tests
  • [ ] Checked for breaking changes and labeled appropriately
  • [ ] Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_5452/

Copy link
Contributor

@thompsongl thompsongl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Used the preview link to confirm the fix; LGTM

@cchaos cchaos merged commit 5b03838 into elastic:main Dec 7, 2021
@cchaos cchaos deleted the fix/link_font_size branch December 7, 2021 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants