[Global reset] Fix reset of button
styles
#5452
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the font-size of the links in our Props docs table were way too big and found that I was originally too heavy-handed with the new global styles for Emotion. Previously, it just set everything to
inherit
, while in the new file I applied our actual font styles. This broke the EuiLink font-size inheritance if the link was actually a<button>
and rendered inside of a sized EuiText block.Before
After
This PR pulls that
button
selector out of the input-specific font global styles and just applies the necessaryfont-family
. It also ensure font-size inheritance by adding it to thereset
file.Checklist
[ ] Props have proper autodocs and playground toggles[ ] Added documentation[ ] Checked Code Sandbox works for any docs examples[ ] Added or updated jest and cypress tests[ ] Checked for breaking changes and labeled appropriately[ ] Checked for accessibility including keyboard-only and screenreader modes