Adding unique IDs to EuiDatePicker Time component options.
#5466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1Copenut
added
accessibility
accessibility - WCAG A
1Copenut
changed the title
EuiDatePicker Time component options.
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5466/ |
Sounds like a bug to me if it was working in legacy but not in Amsterdam - could you file a separate issue for this? (Or if you'd rather fix in this PR, feel free!) |
cee-chen
approved these changes
Dec 14, 2021
thompsongl
approved these changes
Dec 14, 2021
Co-authored-by: Constance <constancecchen@users.noreply.github.com>
|
Thank you EUI reviewers! I've spun out the Amsterdam CSS item as a separate issue so we can merge this PR. I'll pick it up as a fast follow item. #5471 |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5466/ |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UPDATE 12/14:
Question to reviewers below was spun out to a separate issue: #5471
Summary
axe-core was throwing an error for duplicated IDs in our
Timecomponent as part of EuiDatePicker. I added thehtmlGenerator()function and appended a unique string for each LI. PR closes #5304.Question to reviewers
In our legacy theme, the selected time always seems to be centered after click or keypress events. The Amsterdam theme doesn't always center the selected time. Is this expected behavior or a bug?
Checklist
Added documentationAdded or updated **jest and [cypress](https://github.com/elastic/eui/blob/main/wiki/cypress-testing.md) tests**