Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiSuperDatePicker] Pass isDisabled to EuiAutoRefresh #5472

Merged
merged 6 commits into from
Dec 15, 2021

Conversation

thompsongl
Copy link
Contributor

@thompsongl thompsongl commented Dec 14, 2021

Summary

Fixes a bug where EuiAutoRefresh is not disabled when EuiSuperDatePicker is configured with isDisabled.
Also passes through data-test-subj and adds minimal tests for isAutoRefreshOnly.

Checklist

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_5472/

Copy link
Contributor

@cee-chen cee-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA'd and confirmed the fix - thanks for catching this (+ my changelog typo!)

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_5472/

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_5472/

@thompsongl thompsongl merged commit fd1fe19 into elastic:main Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants