Improve EuiBasicTable cell configuration and EuiTable cell content CSS #565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjcenizal
force-pushed
the
bug/table-cell-break-word
branch
2 times, most recently
from
2d3f8c1 to
7d14afb
Compare
snide
reviewed
Mar 22, 2018
| @@ -1,13 +1,16 @@ | |||
| # [`master`](https://github.com/elastic/eui/tree/master) | |||
|
|
|||
| - Adjust `EuiCallOut` and dark theme warning coloring ([#563](https://github.com/elastic/eui/pull/563)) | |||
| - Added a `buttonColor` prop to `EuiConfirmModal` ([#546](https://github.com/elastic/eui/pull/546)) | |||
| - Added 'baseline' as option to `EuiFlexGroup`'s `alignItems` prop ([#546](https://github.com/elastic/eui/pull/546)) | |||
snide
approved these changes
Mar 22, 2018
…extOnly on column definitions, and support passing through unrecognized props to the cell. - Update CSS so that long single-word cell content will break and wrap mid-word.
cjcenizal
force-pushed
the
bug/table-cell-break-word
branch
from
7d14afb to
71f67ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should address some layout problems on elastic/kibana#17344.
EuiBasicTablenow supports explicitly settingtruncateTextandtextOnlyon column definitions, and supports passing through unrecognized props to the cell (e.g.data-test-subj).