Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiIcon] Update user Icon #5877

Merged
merged 4 commits into from
May 6, 2022
Merged

[EuiIcon] Update user Icon #5877

merged 4 commits into from
May 6, 2022

Conversation

opauloh
Copy link
Contributor

@opauloh opauloh commented May 5, 2022

Summary

This PR introduces a new style for the user Icon, that change was proposed by the AWP Design Team to make it more consistent in the library. In most of the cases, we're using outline icons.

Also, as suggested by @miukimiu, we are keeping the current user Icon renamed as userAvatar icon, to cover other use cases in which the current user Icon works better.

cc @codearos @Max-Iskra

Screenshots

Grid

image

Use cases

Session Viewer UI

  • The proposed icon is visually lighter so that it can be used without drawing too much attention.
Current User Icon Proposed User Icon

Avatars

  • In some cases, like Avatars, the current user icon (now userAvatar icon), works better

Checklist

  • Checked in both light and dark modes
  • Checked in mobile
  • Checked in Chrome, Safari, Edge, and Firefox
  • Props have proper autodocs and playground toggles
  • Added documentation
  • Checked Code Sandbox works for any docs examples
  • Added or updated jest and cypress tests
  • Checked for breaking changes and labeled appropriately
  • Updated the Figma library counterpart
  • A changelog entry exists and is marked appropriately

@opauloh opauloh changed the title [EuiIcon] Update user [EuiIcon] Update user Icon May 5, 2022
@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_5877/

@miukimiu miukimiu self-requested a review May 6, 2022 10:50
Copy link
Contributor

@miukimiu miukimiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @opauloh,

Thanks for opening this PR. This new user icon works for your use case when the icon is in line with text, this way it doesn't draw too much attention.

But the old IMO works better for other use cases like avatars.

user-icon@2x

So I would propose to also maintain the old icon and rename it to userAvatar.

@codearos @Max-Iskra can you add the new icon to our Figma library??

@opauloh
Copy link
Contributor Author

opauloh commented May 6, 2022

Hi @miukimiu,

Thanks for reviewing my PR and letting me know about other scenarios, I'll update it to keep the old user icon as userAvatar as you suggested.

@opauloh opauloh marked this pull request as draft May 6, 2022 14:15
@opauloh opauloh marked this pull request as ready for review May 6, 2022 14:42
@opauloh opauloh requested a review from miukimiu May 6, 2022 14:42
@opauloh
Copy link
Contributor Author

opauloh commented May 6, 2022

@miukimiu - Just updated the PR with the userAvatar icon, also updated the Changelog, let me know if need anything else.

cc @codearos / @Max-Iskra

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_5877/

Copy link
Contributor

@miukimiu miukimiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @opauloh. LGTM! 🎉

Teste in Chrome, Safari, Edge, and Firefox.

@opauloh opauloh merged commit b7f6eac into main May 6, 2022
@opauloh opauloh deleted the updating-user-icon branch May 6, 2022 19:12
@codearos
Copy link

codearos commented May 9, 2022

@opauloh @miukimiu Yup, will add new icom to Figma library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants