Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Euisearchbar] Add option to render hint #6319
[Euisearchbar] Add option to render hint #6319
Changes from 6 commits
7f3cdfd
dd53637
ea44af2
d331195
c1aa561
b060ca9
4a653d7
3ba98f0
7fa168b
1205818
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The hint needs to have its
tabindex
removed or set to "-1". Right now it has a tabindex of "0" that allows it to take keyboard focus, but because we're using a portal, it's not a sibling element to the input it represents. This situation could be confusing for users who navigate the screen with sight and assistive technology together.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this something that should be handled globally by the
<EuiInputPopover />
component for every consumer who want to display a popover underneath an<input />
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I looked into it, the
z-index
is set to2000
. Setting it to-1
is not possible as it hides the popover. If this needs to be changed globally for all consumers of theEuiInputPopover
I'd prefer it to be a different PR as I don't know the impact if could have.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I was looking at
tabindex
in the HTML structure. I agreez-index
needs to remain where it is to ensure the popover appears and is above other block elements in the stacking order. A tabindex of -1 ensures the hint cannot take keyboard focus.