add disabled prop to EuiComboBoxOption #650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nreese
changed the title
nreese
force-pushed
the
disabled_option2
branch
from
8bb68bc to
c57ed7d
Compare
cjcenizal
approved these changes
Apr 10, 2018
| @@ -13,6 +13,7 @@ export default class extends Component { | |||
| 'data-test-subj': 'titanOption', | |||
| }, { | |||
| label: 'Enceladus', | |||
| disabled: true, | |||
There was a problem hiding this comment.
Can you change the label to "Enceladus is disabled" to make the example a bit clearer?
| @@ -16,4 +16,8 @@ | |||
| color: $euiColorPrimary; | |||
| background-color: $euiFocusBackgroundColor; | |||
| } | |||
| &:disabled { | |||
There was a problem hiding this comment.
Can we also add a rule to override the hover state:
&:disabled {
color: $euiColorMediumShade;
cursor: not-allowed;
&:hover {
text-decoration: none;
}
}
There was a problem hiding this comment.
Been dealing with these kinds of conflicts a lot lately. Another way to deal with this kind of stuff is to only apply hover states when &:enabled:hover. Cuts out the need for extra specificity overwrites.
No need to do that here, just was a fun realization I had last week and wanted to share. I didn't even know enabled was a thing.
snide
approved these changes
Apr 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am looking into the feasibility of replacing react-select with EuiComboBox in Kibana Visual Builder. One missing feature is the ability to disable options.
This PR just adds a disabled prop to
EuiComboBoxOption