Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiTextArea] Add alert icon when isInvalid and isLoading support #6679

Merged
merged 3 commits into from
Apr 4, 2023

Conversation

cee-chen
Copy link
Contributor

@cee-chen cee-chen commented Apr 4, 2023

Summary

As part of my on-call work this week, I'm finishing up some older backlog work, in this case #2017.

Quick note about this implementation - I'm aware that the text and icons may overlap and be difficult to see or read, but I consider that to be an edge case (most text won't go all the way to the bottom and all the way to the right), and to be a lesser evil than not showing enough information. I'd prefer to wait to see if it becomes an issue, and iterate on it in the future if it does.

Before

After

QA

Remove or strikethrough items that do not apply to your PR.

General checklist

  • Checked in both light and dark modes
  • Checked in mobile
  • Checked in Chrome, Safari, Edge, and Firefox
  • Props have proper autodocs (using @default if default values are missing) and playground toggles
  • A changelog entry exists and is marked appropriately

- [ ] Added or updated jest and cypress tests Existing tests are nonexistent for this component. We should remedy this later in storybook

  • Updated the Figma library counterpart

@cee-chen cee-chen requested a review from breehall April 4, 2023 01:33
@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_6679/

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_6679/

Copy link
Contributor

@breehall breehall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ This looks good to me! Confirmed this in the PR preview by using the display toggles and checking the state. Thanks Cee!

@cee-chen cee-chen merged commit 936b758 into elastic:main Apr 4, 2023
@cee-chen cee-chen deleted the textarea/invalid branch April 4, 2023 20:10
@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_6679/

jbudz added a commit to elastic/kibana that referenced this pull request Apr 18, 2023
EUI `77.0.0` ➡️ `77.1.1`

## [`77.1.0`](https://github.com/elastic/eui/tree/v77.1.0)

- Updated `EuiDatePicker` to display a warning icon and correctly set
`aria-invalid` when `isInvalid` is passed
([#6677](elastic/eui#6677))
- Updated `EuiFilePicker` to display an alert icon when `isInvalid`
([#6678](elastic/eui#6678))
- Updated `EuiTextArea` to display an alert icon when `isInvalid`
([#6679](elastic/eui#6679))
- Updated `EuiTextArea` to support the `isLoading` prop
([#6679](elastic/eui#6679))
- Updated `EuiComboBox` to display a warning icon and correctly set
`aria-invalid` when `isInvalid` is passed
([#6680](elastic/eui#6680))

**Bug fixes**

- Fixed `EuiAccordion` to not set an `aria-expanded` attribute on
non-interactive `buttonElement`s
([#6694](elastic/eui#6694))
- Fixed an `EuiPopoverFooter` bug causing nested popovers within
popovers (note: not a recommended use-case) to unintentionally override
its panel padding size inherited from context
([#6698](elastic/eui#6698))
- Fixed `EuiComboBox` to only delete the last selected item on backspace
if the input caret is present
([#6699](elastic/eui#6699))

---------

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Jon <jon@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants