Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(EuiCode): fix code block copy button not including the last character #6794

Merged
merged 8 commits into from
Jun 2, 2023
Merged

fix(EuiCode): fix code block copy button not including the last character #6794

merged 8 commits into from
Jun 2, 2023

Commits on Jun 2, 2023

  1. fix(EuiCode): fix code block copy button not including the last chara… 

    …cter if it's a question mark
    @tkajtoch
    tkajtoch committed Jun 2, 2023
    Configuration menu
    Copy the full SHA
    3a03d64 View commit details
    Browse the repository at this point in the history

  2. chore: add changelog file

    @tkajtoch
    tkajtoch committed Jun 2, 2023
    Configuration menu
    Copy the full SHA
    4ee0883 View commit details
    Browse the repository at this point in the history

  3. fix(EuiCode): Remove reducing two or more consecutive empty lines to … 

    …a single one when using the Copy button

This change was first introduced in 7aeb30f ([EuiCodeBlock] Replace highlight.js with prism.js via refractor (elastic#4638))
but doesn't seem to be a business or product decision.

We decided to remove it to make the copied content match what's displayed on screen.
    @tkajtoch
    tkajtoch committed Jun 2, 2023
    Configuration menu
    Copy the full SHA
    801cfc6 View commit details
    Browse the repository at this point in the history

  4. Revert "fix(EuiCode): Remove reducing two or more consecutive empty l… 

    …ines to a single one when using the Copy button"

This reverts commit 8a90215c81432514493b1bb29ecd314d6792a05d.
    @tkajtoch
    tkajtoch committed Jun 2, 2023
    Configuration menu
    Copy the full SHA
    171d786 View commit details
    Browse the repository at this point in the history

  5. docs: add clarification comment why \n\n replace is needed

    @tkajtoch
    tkajtoch committed Jun 2, 2023
    Configuration menu
    Copy the full SHA
    91823c3 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'main' into fix/6585-code-block-copy-regex

    @cee-chen
    cee-chen committed Jun 2, 2023
    Configuration menu
    Copy the full SHA
    8632a20 View commit details
    Browse the repository at this point in the history

  7. Update regression test

    @cee-chen
    cee-chen committed Jun 2, 2023
    Configuration menu
    Copy the full SHA
    4b9ae86 View commit details
    Browse the repository at this point in the history

  8. changelog

    @cee-chen
    cee-chen authored Jun 2, 2023
    Configuration menu
    Copy the full SHA
    6b0822b View commit details
    Browse the repository at this point in the history