[Snyk] Upgrade react-virtualized-auto-sizer from 1.0.6 to 1.0.20 #6798

JasonStoltz · 2023-05-23T17:30:59Z

This PR was automatically created by Snyk using the credentials of a real user.

Snyk has created this PR to upgrade react-virtualized-auto-sizer from 1.0.6 to 1.0.15.

ℹ️ Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.

The recommended version is 9 versions ahead of your current version.
The recommended version was released a month ago, on 2023-04-17.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.

For more information:

🧐 View latest project report

🛠 Adjust upgrade PR settings

🔕 Ignore this dependency or unsubscribe from future upgrade PRs

cee-chen · 2023-05-23T20:14:45Z

We should manually QA that EuiAutoSizer works as before before merging this PR in

Snyk has created this PR to upgrade react-virtualized-auto-sizer from 1.0.6 to 1.0.15. See this package in npm: See this project in Snyk: https://app.snyk.io/org/eui/project/782ac3a8-8bb4-4658-baa9-190d6cb035f1?utm_source=github-enterprise&utm_medium=referral&page=upgrade-pr

- might as well grab the absolute latest as it has several type fixes

- lib doesn't export `AutoSizerProps` anymore, so obtain it programmatically

`disableHeight` can't be true and passing the `height` arg at the same time, so we need a new ternary

`disableHeight` can't be true and passing the `height` arg at the same time, so we need a new ternary + refactor virtualized logic to a separate class method, since it has so much unqiue logic + so we're not double nesting ternaries + stricter typing on `calculatedHeight`

- TS now lints/yells about render props args missing explicit types (might be due to React 18 upgrade) - re-export top-level EUI types from the lib, so that consumers don't have to import types directly

- types are already exported from package directly

kibanamachine · 2023-08-11T18:54:04Z

Preview documentation changes for this PR: https://eui.elastic.co/pr_6798_buildkite/

cee-chen · 2023-08-11T18:54:07Z

Changelog

https://github.com/bvaughn/react-virtualized-auto-sizer/blob/master/CHANGELOG.md

1.0.20

Guard against potential state update after unmount (caused by setTimeout when using ResizeObserver)

1.0.19

Further improved TypeScript definitions to avoid any types for children function parameters.
61: Build release bundle with Preconstruct.

1.0.18

Refine TypeScript types so that disableHeight and disableWidth are properly paired with conditional types like children and onResize.

1.0.17

Support non-integer padding styles.

1.0.16

Relaxed children prop return type from ReactElement to ReactNode.

1.0.15

Readme changes

1.0.14

Fix potential "ResizeObserver loop limit exceeded" error caused by long-running renders (#55)

1.0.13

Transpile nullish coalescing operator (#53)

1.0.12

Fix regression introduced in 1.0.8 with transformations; pass unscaled width and height as "default" params (and add additional scaledHeight and scaledWidth params to children function)
Use ResizeObserver when possible; fallback to legacy resize polyfill logic otherwise

1.0.11

Pre-transform static class property syntax (defaultProps) (#46)
Fixed bad TypeScript definition for onResize prop (#44)

1.0.10

Add named exports for AutoSizer as well as Props and Size types.

1.0.9

Add optional tagName property (default to "div").

1.0.8

Replace offsetHeight/offsetWidth with getBoundingClientRect to better support floating size values
Spread all additional props onto out HTMLDivElement

1.0.7

Add peer dependency for "react" / "react-dom" version 18

QA

EuiAutoSizer
EuiCodeBlock (virtualized demo)
EuiSelectable (virtualized demo)

kibanamachine · 2023-08-11T18:56:49Z

Preview documentation changes for this PR: https://eui.elastic.co/pr_6798_buildkite/

kibanamachine · 2023-08-11T19:20:19Z

Preview documentation changes for this PR: https://eui.elastic.co/pr_6798_buildkite/

kibanamachine · 2023-08-11T19:21:11Z

Preview documentation changes for this PR: https://eui.elastic.co/pr_6798_buildkite/

elasticmachine · 2023-08-11T19:37:12Z

💚 Build Succeeded

Buildkite Build
Commit: 4c1181d

History

💚 Build #306 succeeded 4c1181d
💔 Build #294 failed 9f8e702
💔 Build #293 failed 9f8e702

cc @cee-chen

`v86.0.0`⏩`v87.1.0` ⚠️ The biggest set of type changes in this PR come from the breaking change that makes `pageSize` and `pageSizeOptions` now optional props for `EuiBasicTable.pagination`, `EuiInMemoryTable.pagination` and `EuiDataGrid.pagination`. This caused several other components that were cloning EUI's pagination type to start throwing type warnings about `pageSize` being optional. Where I came across these errors, I modified the extended types to require `pageSize`. These types and their usages may end up changing again in any case once the Shared UX team looks into #56406. --- ## [`87.1.0`](https://github.com/elastic/eui/tree/v87.1.0) - Updated the underlying library powering `EuiAutoSizer`. This primarily affects typing around the `disableHeight` and `disableWidth` props ([#6798](elastic/eui#6798)) - Added new `EuiAutoSize`, `EuiAutoSizeHorizontal`, and `EuiAutoSizeVertical` types to support `EuiAutoSizer`'s now-stricter typing ([#6798](elastic/eui#6798)) - Updated `EuiDatePickerRange` to support `compressed` display ([#7058](elastic/eui#7058)) - Updated `EuiFlyoutBody` with a new `scrollableTabIndex` prop ([#7061](elastic/eui#7061)) - Added a new `panelMinWidth` prop to `EuiInputPopover` ([#7071](elastic/eui#7071)) - Added a new `inputPopoverProps` prop for `EuiRange`s and `EuiDualRange`s with `showInput="inputWithPopover"` set ([#7082](elastic/eui#7082)) **Bug fixes** - Fixed `EuiToolTip` overriding instead of merging its `aria-describedby` tooltip ID with any existing `aria-describedby`s ([#7055](elastic/eui#7055)) - Fixed `EuiSuperDatePicker`'s `compressed` display ([#7058](elastic/eui#7058)) - Fixed `EuiAccordion` to remove tabbable children from sequential keyboard navigation when the accordion is closed ([#7064](elastic/eui#7064)) - Fixed `EuiFlyout`s to accept custom `aria-describedby` IDs ([#7065](elastic/eui#7065)) **Accessibility** - Removed the default `dialog` role and `tabIndex` from push `EuiFlyout`s. Push flyouts, compared to overlay flyouts, require manual accessibility management. ([#7065](elastic/eui#7065)) ## [`87.0.0`](https://github.com/elastic/eui/tree/v87.0.0) - Added beta `componentDefaults` prop to `EuiProvider`, which will allow configuring certain default props globally. This list of components and defaults is still under consideration. ([#6923](elastic/eui#6923)) - `EuiPortal`'s `insert` prop can now be configured globally via `EuiProvider.componentDefaults` ([#6941](elastic/eui#6941)) - `EuiFocusTrap`'s `crossFrame` and `gapMode` props can now be configured globally via `EuiProvider.componentDefaults` ([#6942](elastic/eui#6942)) - `EuiTablePagination`'s `itemsPerPage`, `itemsPerPageOptions`, and `showPerPageOptions` props can now be configured globally via `EuiProvider.componentDefaults` ([#6951](elastic/eui#6951)) - `EuiBasicTable`, `EuiInMemoryTable`, and `EuiDataGrid` now allow `pagination.pageSize` to be undefined. If undefined, `pageSize` defaults to `EuiTablePagination`'s `itemsPerPage` component default. ([#6993](elastic/eui#6993)) - `EuiBasicTable`, `EuiInMemoryTable`, and `EuiDataGrid`'s `pagination.pageSizeOptions` will now fall back to `EuiTablePagination`'s `itemsPerPageOptions` component default. ([#6993](elastic/eui#6993)) - Updated `EuiHeaderLinks`'s `gutterSize` spacings ([#7005](elastic/eui#7005)) - Updated `EuiHeaderAlert`'s stacking styles ([#7005](elastic/eui#7005)) - Added `toolTipProps` to `EuiListGroupItem` that allows customizing item tooltips. ([#7018](elastic/eui#7018)) - Updated `EuiBreadcrumbs` to support breadcrumbs that toggle popovers via `popoverContent` and `popoverProps` ([#7031](elastic/eui#7031)) - Improved the contrast ratio of disabled titles within `EuiSteps` and `EuiStepsHorizontal` to meet WCAG AA guidelines. ([#7032](elastic/eui#7032)) - Updated `EuiSteps` and `EuiStepsHorizontal` to highlight and provide a more clear visual indication of the current step ([#7048](elastic/eui#7048)) **Bug fixes** - Single uses of `<EuiHeaderSectionItem side="right" />` now align right as expected without needing a previous `side="left"` sibling. ([#7005](elastic/eui#7005)) - `EuiPageTemplate` now correctly displays `panelled={true}` ([#7044](elastic/eui#7044)) **Breaking changes** - `EuiTablePagination`'s default `itemsPerPage` is now `10` (was previously `50`). This can be configured through `EuiProvider.componentDefaults`. ([#6993](elastic/eui#6993)) - `EuiTablePagination`'s default `itemsPerPageOptions` is now `[10, 25, 50]` (was previously `[10, 20, 50, 100]`). This can be configured through `EuiProvider.componentDefaults`. ([#6993](elastic/eui#6993)) - Removed `border` prop from `EuiHeaderSectionItem` (unused since Amsterdam theme) ([#7005](elastic/eui#7005)) - Removed `borders` object configuration from `EuiHeader.sections` ([#7005](elastic/eui#7005)) **CSS-in-JS conversions** - Converted `EuiHeaderAlert` to Emotion; Removed unused `.euiHeaderAlert__dismiss` CSS ([#7005](elastic/eui#7005)) - Converted `EuiHeaderSection`, `EuiHeaderSectionItem`, and `EuiHeaderSectionItemButton` to Emotion ([#7005](elastic/eui#7005)) - Converted `EuiHeaderLinks` and `EuiHeaderLink` to Emotion; Removed `$euiHeaderLinksGutterSizes` Sass variables ([#7005](elastic/eui#7005)) - Removed `$euiHeaderBackgroundColor` Sass variable; use `$euiColorEmptyShade` instead ([#7005](elastic/eui#7005)) - Removed `$euiHeaderChildSize` Sass variable; use `$euiSizeXXL` instead ([#7005](elastic/eui#7005)) --------- Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Patryk Kopyciński <contact@patrykkopycinski.com>

cee-chen added skip-changelog tech debt labels May 23, 2023

snyk-bot and others added 6 commits August 11, 2023 09:43

Update react-virtualized-auto-sizer to latest

71ab3bf

- might as well grab the absolute latest as it has several type fixes

Fix component props export

b1f9b33

- lib doesn't export `AutoSizerProps` anymore, so obtain it programmatically

[EuiCodeBlock] Fix for new stringent EuiAutoSizer typing

f3ace72

`disableHeight` can't be true and passing the `height` arg at the same time, so we need a new ternary

Fix typescript issues

a76c7e3

- TS now lints/yells about render props args missing explicit types (might be due to React 18 upgrade) - re-export top-level EUI types from the lib, so that consumers don't have to import types directly

cee-chen force-pushed the snyk-upgrade-36d60602c40679bce354b0273d5befff branch from 9f8e702 to a76c7e3 Compare August 11, 2023 18:27

cee-chen changed the title ~~[Snyk] Upgrade react-virtualized-auto-sizer from 1.0.6 to 1.0.15~~ [Snyk] Upgrade react-virtualized-auto-sizer from 1.0.6 to 1.0.20 Aug 11, 2023

Remove unused @types dependency

1b389b6

- types are already exported from package directly

changelog

4c1181d

cee-chen added typescript and removed skip-changelog labels Aug 11, 2023

cee-chen enabled auto-merge (squash) August 11, 2023 18:58

cee-chen self-assigned this Aug 11, 2023

cee-chen mentioned this pull request Aug 11, 2023

[bug][CI] Buildkite jobs on elastic branches run twice #7069

Closed

cee-chen merged commit fe6d803 into main Aug 11, 2023

cee-chen approved these changes Aug 11, 2023

View reviewed changes

cee-chen deleted the snyk-upgrade-36d60602c40679bce354b0273d5befff branch August 11, 2023 19:42

cee-chen mentioned this pull request Aug 15, 2023

Upgrade EUI to v87.1.0 elastic/kibana#163961

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Snyk] Upgrade react-virtualized-auto-sizer from 1.0.6 to 1.0.20 #6798

[Snyk] Upgrade react-virtualized-auto-sizer from 1.0.6 to 1.0.20 #6798

JasonStoltz commented May 23, 2023

cee-chen commented May 23, 2023

kibanamachine commented Aug 11, 2023

cee-chen commented Aug 11, 2023 •

edited

Loading

kibanamachine commented Aug 11, 2023

kibanamachine commented Aug 11, 2023

kibanamachine commented Aug 11, 2023

elasticmachine commented Aug 11, 2023

[Snyk] Upgrade react-virtualized-auto-sizer from 1.0.6 to 1.0.20 #6798

[Snyk] Upgrade react-virtualized-auto-sizer from 1.0.6 to 1.0.20 #6798

Conversation

JasonStoltz commented May 23, 2023

Snyk has created this PR to upgrade react-virtualized-auto-sizer from 1.0.6 to 1.0.15.

cee-chen commented May 23, 2023

kibanamachine commented Aug 11, 2023

cee-chen commented Aug 11, 2023 • edited Loading

Changelog

1.0.20

1.0.19

1.0.18

1.0.17

1.0.16

1.0.15

1.0.14

1.0.13

1.0.12

1.0.11

1.0.10

1.0.9

1.0.8

1.0.7

QA

kibanamachine commented Aug 11, 2023

kibanamachine commented Aug 11, 2023

kibanamachine commented Aug 11, 2023

elasticmachine commented Aug 11, 2023

💚 Build Succeeded

History

cee-chen commented Aug 11, 2023 •

edited

Loading