[Emotion] Further enhance shouldRenderCustomStyles
#6907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- use an obj API for skips - programmatically generate props objects as well as test titles based on skips
- to components that spread style to a different DOM node than `className` - we can now add these tests thanks to the new `targetSelector` API and granular skips
cee-chen
changed the title
shouldRenderCustomStylesshouldRenderCustomStyles
cee-chen
added
skip-changelog
testing
cee-chen
commented
Jul 5, 2023
Comment on lines
-70
to
+99
| const testCases = options.skipStyles | ||
| ? 'classNames and css' | ||
| : 'classNames, css, and styles'; | ||
| const testProps = options.skipStyles | ||
| ? { className: customStyles.className, css: customStyles.css } | ||
| : customStyles; | ||
| // Account for any skipped props | ||
| const testProps = keysOf(customStyles).reduce((map, key) => { | ||
| return options.skip?.[key] ? map : { ...map, [key]: customStyles[key] }; | ||
| }, {} as Partial<typeof customStyles>); | ||
|
|
||
| // Generate a grammatically excellent list of props being tested | ||
| let propsToTest = ''; | ||
| const propsToTestArr = Object.keys(testProps); | ||
| switch (propsToTestArr.length) { | ||
| case 1: | ||
| propsToTest = propsToTestArr[0]; | ||
| break; | ||
| case 2: | ||
| propsToTest = `${propsToTestArr[0]} and ${propsToTestArr[1]}`; | ||
| break; | ||
| // You'll pry the oxford comma from my cold dead hands | ||
| default: | ||
| propsToTest = `${propsToTestArr | ||
| .slice(0, -1) | ||
| .join(', ')}, and ${propsToTestArr.slice(-1)}`; | ||
| break; | ||
| } |
There was a problem hiding this comment.
Screencap of what this should output put grammatically in test titles, based on number of props being tested:
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_6907/ |
1Copenut
approved these changes
Jul 5, 2023
|
🎉 Thanks again Trevor! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is some final extra/optional work on top of #6896 - I didn't want to include it in the above PR as that was was big enough as it was. I recommend reviewing by commit and turning off whitespace diffs.
skipStylesAPI - now usesskip: { style: true }skipParentTestAPI, now usesskip: { parentTest: true }skipAPI which allows for granular skipping, e.g.skip: { css: true }...restspread - add tests that actually checks that consumer styles are correctly applied)QA
General checklist
N/A, internal dev/tech debt only